Return-Path: Delivered-To: apmail-maven-issues-archive@locus.apache.org Received: (qmail 55176 invoked from network); 31 Aug 2006 08:50:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 31 Aug 2006 08:50:34 -0000 Received: (qmail 65558 invoked by uid 500); 31 Aug 2006 08:50:33 -0000 Delivered-To: apmail-maven-issues-archive@maven.apache.org Received: (qmail 65504 invoked by uid 500); 31 Aug 2006 08:50:33 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 65495 invoked by uid 99); 31 Aug 2006 08:50:33 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Aug 2006 01:50:33 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [63.246.20.114] (HELO 63-246-20-114.contegix.com) (63.246.20.114) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Aug 2006 01:50:30 -0700 Received: (qmail 29890 invoked by uid 89); 31 Aug 2006 08:49:48 -0000 Received: from unknown (HELO codehaus01.managed.contegix.com) (127.0.0.1) by smtp.domain.com with SMTP; 31 Aug 2006 08:49:48 -0000 Message-ID: <85659465.1157014188595.JavaMail.haus-jira@codehaus01.managed.contegix.com> Date: Thu, 31 Aug 2006 03:49:48 -0500 (CDT) From: "Emmanuel Renaud (JIRA)" To: issues@maven.apache.org Subject: [jira] Created: (MAVEN-1786) Performance Optimization of the Reactor MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Performance Optimization of the Reactor --------------------------------------- Key: MAVEN-1786 URL: http://jira.codehaus.org/browse/MAVEN-1786 Project: Maven Issue Type: Improvement Affects Versions: 1.1-beta-2 Environment: OS windows xp, JVM sun 1.4.2 Reporter: Emmanuel Renaud Attachments: Goal.java, reactor-jprofiler.GIF The Goal.checkForCycle method is a hotspot as the reactor starts. Most of the time is spent in creating HashSets and filling them (see attached screen shot). Instead of creating a new HasSet each time, reusing the same improves the performance of dependency analysis (see attached file Goal.java). Due to security policy in my company I can't checkout the sources and run non-regression tests, at least it works fine on our project. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira