Return-Path: 
 <issues-return-8287-apmail-maven-issues-archive=maven.apache.org@maven.apache.org>
Delivered-To: apmail-maven-issues-archive@locus.apache.org
Received: (qmail 82064 invoked from network); 27 Jul 2006 21:39:54 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 27 Jul 2006 21:39:54 -0000
Received: (qmail 3032 invoked by uid 500); 27 Jul 2006 21:39:53 -0000
Delivered-To: apmail-maven-issues-archive@maven.apache.org
Received: (qmail 2982 invoked by uid 500); 27 Jul 2006 21:39:53 -0000
Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@maven.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@maven.apache.org>
List-Post: <mailto:issues@maven.apache.org>
List-Id: <issues.maven.apache.org>
Reply-To: dev@maven.apache.org
Delivered-To: mailing list issues@maven.apache.org
Received: (qmail 2973 invoked by uid 99); 27 Jul 2006 21:39:53 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Jul 2006 14:39:53 -0700
X-ASF-Spam-Status: No, hits=0.5 required=10.0
	tests=DNS_FROM_RFC_ABUSE
X-Spam-Check-By: apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Received: from [63.246.20.114] (HELO 63-246-20-114.contegix.com)
 (63.246.20.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Jul 2006 14:39:53 -0700
Received: (qmail 21749 invoked by uid 89); 27 Jul 2006 21:39:32 -0000
Received: from unknown (HELO codehaus01.managed.contegix.com) (127.0.0.1)
  by smtp.domain.com with SMTP; 27 Jul 2006 21:39:32 -0000
Message-ID: 
 <98034554.1154036372396.JavaMail.haus-jira@codehaus01.managed.contegix.com>
Date: Thu, 27 Jul 2006 16:39:32 -0500 (CDT)
From: "Brett Porter (JIRA)" <jira@codehaus.org>
To: issues@maven.apache.org
Subject: [jira] Commented: (CONTINUUM-783) Use standard jstl for links or
 they will break
In-Reply-To: 
 <82835921.1153509925450.JavaMail.haus-jira@codehaus01.managed.contegix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

    [ http://jira.codehaus.org/browse/CONTINUUM-783?page=comments#action_70941 ] 
            
Brett Porter commented on CONTINUUM-783:
----------------------------------------

while those no need to change the existing ones, you might like to use <ww:url/> for the other links. It is basically the same, but let's you specify it in terms of namespace, action and method.

> Use standard jstl for links or they will break
> ----------------------------------------------
>
>                 Key: CONTINUUM-783
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-783
>             Project: Continuum
>          Issue Type: Bug
>          Components: Web interface
>            Reporter: Carlos Sanchez
>         Assigned To: Henry S. Isidro
>             Fix For: 1.1
>
>         Attachments: CONTINUUM-778-continuum-webapp.patch
>
>
> I see a lot of links constructed like this
>               <a href="${pageContext.request.contextPath}/deleteUser!doDelete.action?accountId=${pageScope.user.accountId}&username=${pageScope.user.username}"><ww:text name="delete"/></a>
> This will break under certain circustancies, like cookies disabled or variables with some chars that need to be encoded
> Also jstl automatically adds the contextPath at the beggining
> See http://www-128.ibm.com/developerworks/java/library/j-jstl0318/#N105D3 for more info
> The right way do do it is
>               <c:url var="deleteUserUrl" value="/deleteUser!doDelete.action">
>                 <c:param name="accountId" value="${user.accountId}"/>
>                 <c:param name="username" value="${user.username}"/>
>               </c:url>
>               <a href="<c:out value='${deleteUserUrl}'/>"><ww:text name="delete"/></a>
> when no parameters need to be added it can just be
>               <a href="<c:url value="/deleteUser!doDelete.action">"><ww:text name="delete"/></a>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira