in both <properties> and <head>, so throwing an Exception is not the >> right solution IMO. I would prefer one of the following two alternatives: > > Yes both are legal, but the doc doesn't specify which one is the > "official" title of a xdoc. properties/title is required by the xsd and should have priority, head/title is only there for compatibility with xhtml, but it is optional. > >> 1) define and document which title gets used if both are specified and emit >> a warning that the other is ignored > > I was thinking about this idea but due to the parser impl, it will be > always head/title which emits a warn due to the exception actually. > > IMHO head/title should be the right title, properties/title is more > for backward compatibility reasons. WDYT? The other way round IMO. The properties/title is a required element, while head/title is optional, and properties comes before head, so simply emit a warning when a second title is encountered. -Lukas > > Cheers, >

Return-Path: Delivered-To: apmail-maven-doxia-dev-archive@www.apache.org Received: (qmail 29306 invoked from network); 20 Aug 2009 07:50:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 20 Aug 2009 07:50:55 -0000 Received: (qmail 94367 invoked by uid 500); 20 Aug 2009 07:51:14 -0000 Delivered-To: apmail-maven-doxia-dev-archive@maven.apache.org Received: (qmail 94315 invoked by uid 500); 20 Aug 2009 07:51:14 -0000 Mailing-List: contact doxia-dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: doxia-dev@maven.apache.org Delivered-To: mailing list doxia-dev@maven.apache.org Received: (qmail 94305 invoked by uid 99); 20 Aug 2009 07:51:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Aug 2009 07:51:14 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [130.225.212.6] (HELO mail2.nbi.dk) (130.225.212.6) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Aug 2009 07:51:03 +0000 Received: from [130.225.212.224] (theussl.nbi.dk [130.225.212.224]) by mail2.nbi.dk (Postfix) with ESMTP id A9EED3C8A4 for ; Thu, 20 Aug 2009 09:50:43 +0200 (CEST) Message-ID: <4A8D010C.7080505@apache.org> Date: Thu, 20 Aug 2009 09:53:48 +0200 From: Lukas Theussl Organization: Apache Software Foundation User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.22) Gecko/20090606 SeaMonkey/1.1.17 MIME-Version: 1.0 To: doxia-dev@maven.apache.org Subject: Re: svn commit: r805576 - in /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src: main/java/org/apache/maven/doxia/module/xdoc/XdocParser.java test/java/org/apache/maven/doxia/module/xdoc/XdocParserTest.java References: <20090818210424.6D2FC23888BD@eris.apache.org> <4A8BAAC7.9000609@apache.org> <9ae367340908190217s7038f288seeed85a9480311ef@mail.gmail.com> In-Reply-To: <9ae367340908190217s7038f288seeed85a9480311ef@mail.gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Vincent Siveton wrote: > Hi Lukas, > > 2009/8/19 Lukas Theussl : >> IIUC, according to the xdoc schema it is perfectly legal to specify a >> in both <properties> and <head>, so throwing an Exception is not the >> right solution IMO. I would prefer one of the following two alternatives: > > Yes both are legal, but the doc doesn't specify which one is the > "official" title of a xdoc. properties/title is required by the xsd and should have priority, head/title is only there for compatibility with xhtml, but it is optional. > >> 1) define and document which title gets used if both are specified and emit >> a warning that the other is ignored > > I was thinking about this idea but due to the parser impl, it will be > always head/title which emits a warn due to the exception actually. > > IMHO head/title should be the right title, properties/title is more > for backward compatibility reasons. WDYT? The other way round IMO. The properties/title is a required element, while head/title is optional, and properties comes before head, so simply emit a warning when a second title is encountered. -Lukas > > Cheers, > > Vincent >