maven-doxia-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lukas Theussl <ltheu...@apache.org>
Subject Re: additions to sink api
Date Fri, 29 Feb 2008 06:31:24 GMT
It's badly expressed, the 'lower-case' is just a recommendation for new 
attributes, the emphasis is on String. Apart from casting to String I 
don't put any restrictions on the key/value pairs (old-style HTML 
upper-case attributes also have to be supported). I will review the 
javadocs anyway.

-Lukas


Vincent Siveton wrote:
> +1
> 
> My only interrogation is why keys *and* values needs to be in lower
> case... I refer to style which could contains both.
> 
> Cheers,
> 
> Vincent
> 
> 2008/2/28, Lukas Theussl <ltheussl@apache.org>:
> 
>>Hi,
>>
>> Following the discussions around DOXIA-204 [1] I have implemented the
>> idea there, ie added a SinkEventAttributes parameter to all the relevant
>> sink methods, for instance
>>
>> public void figure( SinkEventAttributes attributes );
>>
>> I am still testing it with the little time I have available currently
>> but it seems to work and I'd be ready to commit it on beta-1 trunk. As
>> noted at DOXIA-204, this will solve (or allow to solve) a whole bunch of
>> issues, but brings us one step further away from backward compatibility
>> with the alpha branch (which is however already broken in current trunk
>> anyway).
>>
>> I have deployed my javadocs of doxia-sink-api [2], let me know if you
>> have any comments on the design or if I can go ahead.
>>
>> Thanks,
>> -Lukas
>>
>>
>> [1] http://jira.codehaus.org/browse/DOXIA-204
>> [2]
>> http://people.apache.org/~ltheussl/staging-sites/doxia-sink-api/site/apidocs/
>>
> 
> 

Mime
View raw message