maven-doxia-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dennis Lundberg <denn...@apache.org>
Subject Re: svn commit: r595592 - /maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site.vm
Date Sun, 18 Nov 2007 19:23:59 GMT
Should we be hardcoding the width and height of the PoweredBy logo? What 
if someone wants to use a differently sized logo? It would then be 
shrinked or expanded, resulting in a possibly distorted image.

ltheussl@apache.org wrote:
> Author: ltheussl
> Date: Fri Nov 16 00:49:16 2007
> New Revision: 595592
> 
> URL: http://svn.apache.org/viewvc?rev=595592&view=rev
> Log:
> [DOXIASITETOOLS-3] Add titles to hrefs, tweaks to powered by
> Submitted by: Tim Pizey
> 
> Modified:
>     maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site.vm
> 
> Modified: maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site.vm
> URL: http://svn.apache.org/viewvc/maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site.vm?rev=595592&r1=595591&r2=595592&view=diff
> ==============================================================================
> --- maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site.vm
(original)
> +++ maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/main/resources/org/apache/maven/doxia/siterenderer/resources/default-site.vm
Fri Nov 16 00:49:16 2007
> @@ -11,9 +11,9 @@
>  #macro ( banner $banner $id )
>    #if ( $banner )
>      #if( $banner.href )
> -      <a href="$banner.href" id="$id">
> +      <a href="$banner.href" id="$id" #if( $banner.alt ) title="$banner.alt" #end
>
>      #else
> -        <span id="$id">
> +        <div id="$id">
>      #end
>  
>      #if( $banner.src )
> @@ -25,7 +25,7 @@
>          #if ( $banner.alt )
>              #set ( $alt = $banner.alt )
>          #else
> -            #set ( $alt = "" )
> +            #set ( $alt = $banner.name )
>          #end
>          <img src="$src" alt="$alt" />
>      #else
> @@ -35,7 +35,7 @@
>      #if( $banner.href )
>          </a>
>      #else
> -        </span>
> +        </div>
>      #end
>    #end
>  #end
> @@ -76,7 +76,7 @@
>      #foreach( $subitem in $item.items )
>        #set ( $subitemHref = $PathTool.calculateLink( $subitem.href, $relativePath )
)
>        #set ( $subitemHref = $subitemHref.replaceAll( "\\", "/" ) )
> -
> +      #set ( $display = false )
>        #if ( $alignedFileName == $subitemHref )
>          #set ( $display = true )
>        #end
> @@ -187,6 +187,9 @@
>      #else
>        #set ( $versionPosition = "left" )
>      #end
> +  #else
> +    #set ( $version = "" )
> +    #set ( $versionPosition = "left" )
>    #end
>  
>    #set ( $breadcrumbs = $decoration.body.breadcrumbs )
> @@ -272,17 +275,33 @@
>              <a href="$href" title="$name" class="poweredBy">
>                #set ( $img = $PathTool.calculateLink( $img, $relativePath ) )
>                #set ( $img = $img.replaceAll( "\\", "/" ) )
> -              <img alt="$name" src="$img" />
> +              <img  class="poweredBy"  
> +                    alt="$name" 
> +                    src="$img" 
> +                    width="90"
> +                    height="30"
> +              />
>              </a>
>          #end
>          #if( $poweredBy.isEmpty() )
>            <a href="http://maven.apache.org/" title="$i18n.getString( "site-renderer",
$locale, "template.builtby" ) Maven" class="poweredBy">
> -            <img alt="$i18n.getString( "site-renderer", $locale, "template.builtby"
) Maven" src="$relativePath/images/logos/maven-feather.png"></img>
> +            <img class="poweredBy" 
> +                 alt="$i18n.getString( "site-renderer", $locale, "template.builtby"
) Maven" 
> +                 src="$relativePath/images/logos/maven-feather.png" 
> +                 width="90"
> +                 height="30"
> +                 border="1" />
>            </a>
>          #end
>      #else
>          <a href="http://maven.apache.org/" title="$i18n.getString( "site-renderer",
$locale, "template.builtby" ) Maven" class="poweredBy">
> -          <img alt="$i18n.getString( "site-renderer", $locale, "template.builtby"
) Maven" src="$relativePath/images/logos/maven-feather.png"></img>
> +          <img class="poweredBy" 
> +               alt="$i18n.getString( "site-renderer", $locale, "template.builtby" )
Maven" 
> +               src="$relativePath/images/logos/maven-feather.png" 
> +               width="90"
> +               height="30"
> +               border="1"
> +               />
>          </a>
>      #end
>  #end
> 
> 
> 


-- 
Dennis Lundberg

Mime
View raw message