maven-doxia-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dennis Lundberg <denn...@apache.org>
Subject Re: Doxia core clean up
Date Fri, 03 Aug 2007 21:56:08 GMT
Vincent Siveton wrote:
> Hi,
> 
> 2007/8/3, Dennis Lundberg <dennisl@apache.org>:
>> Vincent Siveton wrote:
>>> Hi,
>>>
>>> Several utility classes in Doxia are few used or unused.
>>> org.apache.maven.doxia.util.StringUtil (used only in
>>> XmlWriterXdocSink, which is not maintained)
>>> org.apache.maven.doxia.util.FileUtil (used only in DocBookSink)
>>> org.apache.maven.doxia.util.WrappedException (unused)
>>>
>>> I propose to remove them and to use Plexus-utils instead of. It would
>>> be a part of DOXIA-56.
>> Sounds good to me.
>>
>>> Also, I propose to rename the following package
>>> org.apache.maven.doxia.site.module.manager
>>> to
>>> org.apache.maven.doxia.module.manager
>> What would be the benefit of that move? The JavaDoc says that it is a
>> hook for doxia site tools, so the package "site" makes sense to me.
>> Perhaps change it to org.apache.maven.doxia.sitetools.module.manager
>> instead?
> 
> Typo, I would say o.a.m.doxia.module.SITE.manager. As you said, site
> makes sense.
> 
> By convention, all modules use o.a.m.d.module.XXX as package name, and
> several of them implements SiteModule. IMHO the site package should be
> in the module package because it is module specific.
> 
> Thoughts?

Yes, that is good.

> 
> Vincent
> 
> 
>>> WDYT?
>>>
>>> Vincent
>>
>> --
>> Dennis Lundberg
>>


-- 
Dennis Lundberg

Mime
View raw message