maven-doxia-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent Siveton" <vincent.sive...@gmail.com>
Subject Re: svn commit: r560737 [1/2] - in /maven/doxia/doxia/trunk/doxia-modules: doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc/ doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/ doxia-module-xhtml/src/main/java/org/ap
Date Sun, 29 Jul 2007 20:31:06 GMT
Hi Dennis,

2007/7/29, Dennis Lundberg <dennisl@apache.org>:
> A couple of thoughts on the changes to xdoc, and in some cases also xhtml:
>
> - From what I can tell the output of EOL chars in XdocSink and XhtmlSink
> has changed with this commit. Was that intended? After this commit only
> "simple" tags and end tags get an EOL.

Actually intended but need to be improved. See below.

> - Changing the tests to ignore EOL chars might be dangerous if we care
> about where the EOLs are put.

A lot of modules use EOL or \n inside. We need to review them to be
more consistent and use only system EOL.
About testing, the new AbstractSinkTest class has this convenience
method but like you said, we need to take care about EOL in the
future.

> - I think we should try to pretty print the sink output to the best of
> our capabilities.

Totally agree with you. I think we need to use the
PrettyPrintXMLWriter class from Plexus utils (or other) to correctly
indent the output.I didn't want to change it with this commit, to be
sure to not have side effects. Thoughts?

Thanks,

Vincent

>
> vsiveton@apache.org wrote:
> > Author: vsiveton
> > Date: Sun Jul 29 08:40:13 2007
> > New Revision: 560737
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=560737
> > Log:
> > o Put all hardcoded markups in an interface
> > o using javax.swing.text.html.HTML.Tag and javax.swing.text.html.HTML.Attribute
instead of harcoded tags/attributes
> > o updated javadocs
> >

[SNIP]

Mime
View raw message