maven-doxia-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lukas Theussl <ltheu...@apache.org>
Subject Re: svn commit: r558543 - /maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
Date Sun, 22 Jul 2007 20:51:35 GMT
I have reverted part of my commit, tests are passing now again, however, 
I had to comment out a few asserts in DefaultSiteRendererTest.java. I am 
not quite sure how these tests could ever have passed: eg for the 
following html segment

             <ul>
                 <li>
                     Item 1.
                     <ul>
                         <li>
                             <p>Item 11.</p>
                         </li>
                         <li>
                             <p>Item 12.</p>
                         </li>
                         <li>
                             Item 13.
                         </li>
                         <li>
                             Item 14.
                         </li>
                     </ul>
                 </li>

the expression ul.getFirstChild().asText() returns "Item 1. Item 11. 
Item 12. Item 13. Item 14." , which is correct if I understand the 
htmlunit javadocs correctly. But the test asserted an empty string. Am I 
still missing something?

Cheers,
-Lukas


ltheussl@apache.org wrote:
> Author: ltheussl
> Date: Sun Jul 22 13:38:24 2007
> New Revision: 558543
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=558543
> Log:
> Comment out failing tests, - need to clarify.
> 
> Modified:
>     maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
> 
> Modified: maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
> URL: http://svn.apache.org/viewvc/maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java?view=diff&rev=558543&r1=558542&r2=558543
> ==============================================================================
> --- maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
(original)
> +++ maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
Sun Jul 22 13:38:24 2007
> @@ -176,7 +176,8 @@
>  
>          HtmlUnorderedList ul = (HtmlUnorderedList) elementIterator.next();
>          assertNotNull( ul );
> -        assertEquals( ul.getFirstChild().asText(), "" );
> +        // TODO: how can this be?
> +        //assertEquals( ul.getFirstChild().asText(), "" );
>  


Mime
View raw message