Mailing-List: contact doxia-dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: doxia-dev@maven.apache.org
Received-SPF: pass (herse.apache.org: domain of vincent.siveton@gmail.com
 designates 66.249.92.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=FxhALzsDBGBscu14CksseFIu11yti7TKzZvhO5vW7bK+4+pG8/3Rv78GAqRJct2NBSI+yaw7zvscOagnSn+hbU+Xsq1dczXOsxMb5cPypftLG8BwwWyqbdvxxWu2SVrtAzSWg/PtWe/OdwptmLCK46cPuQKVbu40mD+Tgi9GIdc=
Message-ID: <9ae367340705281740i7d989b50wed356a33fa0a09fd@mail.gmail.com>
Date: Mon, 28 May 2007 20:40:17 -0400
From: "Vincent Siveton" <vincent.siveton@gmail.com>
To: doxia-dev@maven.apache.org
Subject: Re: svn commit: r542363 -
 /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc/XmlWriterXdocSink.java
In-Reply-To: <D76660BD-D80A-460C-BCD7-6E56691FAB03@maven.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070529001145.45C791A981A@eris.apache.org>
	 <D76660BD-D80A-460C-BCD7-6E56691FAB03@maven.org>

np!

Cheers,

Vincent

2007/5/28, Jason van Zyl <jason@maven.org>:
> Sorry about that, thought I was building with 1.4. We need the
> enforcer plugin :-)
>
> On 28 May 07, at 8:11 PM 28 May 07, vsiveton@apache.org wrote:
>
> > Author: vsiveton
> > Date: Mon May 28 17:11:44 2007
> > New Revision: 542363
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=542363
> > Log:
> > DOXIA-113:  Can't build doxia with jdk1.4 in rev 542303
> > Submitted by: Olivier Lamy
> > Reviewed by: Vincent Siveton
> >
> > o patch applied
> >
> > Modified:
> >     maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/
> > main/java/org/apache/maven/doxia/module/xdoc/XmlWriterXdocSink.java
> >
> > Modified: maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/
> > src/main/java/org/apache/maven/doxia/module/xdoc/
> > XmlWriterXdocSink.java
> > URL: http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-
> > modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/
> > module/xdoc/XmlWriterXdocSink.java?
> > view=diff&rev=542363&r1=542362&r2=542363
> > ======================================================================
> > ========
> > --- maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/
> > main/java/org/apache/maven/doxia/module/xdoc/XmlWriterXdocSink.java
> > (original)
> > +++ maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/
> > main/java/org/apache/maven/doxia/module/xdoc/XmlWriterXdocSink.java
> > Mon May 28 17:11:44 2007
> > @@ -1,4 +1,4 @@
> > -package org.codehaus.doxia.module.xdoc;
> > +package org.apache.maven.doxia.module.xdoc;
> >
> >  /*
> >   * Licensed to the Apache Software Foundation (ASF) under one
> > @@ -19,11 +19,12 @@
> >   * under the License.
> >   */
> >
> > -import org.apache.maven.doxia.util.HtmlTools;
> > -import org.apache.maven.doxia.sink.SinkAdapter;
> > +import org.apache.maven.doxia.parser.Parser;
> > +import org.apache.maven.doxia.sink.SinkAdapter;
> >  import org.apache.maven.doxia.sink.StructureSink;
> > +import org.apache.maven.doxia.util.HtmlTools;
> > +import org.apache.maven.doxia.util.StringUtil;
> >  import org.codehaus.plexus.util.xml.XMLWriter;
> > -import org.apache.maven.doxia.parser.Parser;
> >
> >  /**
> >   * A doxia Sink which produces an xdoc document.
> > @@ -54,7 +55,6 @@
> >              throw new IllegalArgumentException("argument can't be
> > null");
> >          }
> >          this.writer = writer;
> > -
> >      }
> >
> >      protected void resetState()
> > @@ -81,8 +81,8 @@
> >      public void head_()
> >      {
> >          headFlag = false;
> > -
> > -        writer.endElement(); // properties
> > +
> > +        writer.endElement(); // properties
> >      }
> >
> >      public void title_()
> > @@ -402,7 +402,6 @@
> >              }
> >          }
> >
> > -
> >          writer.startElement("t" + ( headerRow ? 'h' : 'd' ));
> >          if ( justif != null )
> >              writer.addAttribute("align", justif);
> > @@ -535,7 +534,7 @@
> >          {
> >              buffer.append( text );
> >          }
> > -        else if ( sectionTitleFlag )
> > +        else if ( sectionTitleFlag )
> >          {
> >              buffer.append( text );
> >          }
> > @@ -564,7 +563,7 @@
> >
> >      protected void verbatimContent( String text )
> >      {
> > -        writer.writeText( text.replace(" ", "&nbsp;"));
> > +        writer.writeText( StringUtil.replaceAll( text, " ",
> > "&nbsp;" ) );
> >      }
> >
> >      public static String escapeHTML( String text )
> >
> >
> >
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder and PMC Chair, Apache Maven
> jason at sonatype dot com
> ----------------------------------------------------------
>
>
>
>