From dev-return-128616-archive-asf-public=cust-asf.ponee.io@maven.apache.org Thu Jul 18 12:48:54 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A7FA918063F for ; Thu, 18 Jul 2019 14:48:54 +0200 (CEST) Received: (qmail 85921 invoked by uid 500); 18 Jul 2019 12:48:53 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 85909 invoked by uid 99); 18 Jul 2019 12:48:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jul 2019 12:48:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 00465C2D74 for ; Thu, 18 Jul 2019 12:48:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.8 X-Spam-Level: * X-Spam-Status: No, score=1.8 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id IcpvlM0W1lJC for ; Thu, 18 Jul 2019 12:48:50 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::232; helo=mail-lj1-x232.google.com; envelope-from=mindcooler@gmail.com; receiver= Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 1A40D7DC5E for ; Thu, 18 Jul 2019 12:48:50 +0000 (UTC) Received: by mail-lj1-x232.google.com with SMTP id h10so27230697ljg.0 for ; Thu, 18 Jul 2019 05:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=UrPNB9Dd2fTVDp3UE5T09pFKz9eKR2eSilAwrovcTfo=; b=slvFA/u8Yrk4tF/DwjL7hanamF3OgXhLUszNMrN0TOoZqRbcuIM6yd6OKMfTfJTm4d E4b1g4zTZyXWkiAW3RbZ7WG83GY1a5OzvHHuF2zAmxbZ696jhQjTI9A2plYoUicJp1v1 htcf/TIzLetIh8jPhfoVd6RrENThkGWumffZymopCa6xtXNbRw/e1ziM0io5rXZLubI3 YPs18IxNseurP49lPZnvISneZ/7VCuPg3j2d/nuvg2VdSkWgiYkmDImEVtesxBn7NxeC H6SEJIY4nW+ONp4QRW+wbePYQyR2aUVRxsd7iOj98Zo6dTdy8jSwMtHvDApX1/AjS35F w/3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=UrPNB9Dd2fTVDp3UE5T09pFKz9eKR2eSilAwrovcTfo=; b=SyITxQRVDYPY2Q4ezYXdZRlmAVUFbBI0GGZac6mZ70gjbgdKWMpfLVNdgQxcLmcOX4 EOVdTNs+XZQI5RiUjYc6Xu+BDPIDIgWcmvBk0kIIh8z/U79Z6RuecwJ7eHFlkjRepJxO rXmUcFpyyfWst2Tt+Le5tK6r9aKytYvaRR4vfp1Un4UG27bV0I1ZWdeHUjzOLt9MGGKT t5jZqhZ3ISedp618AqQOEjmzlYEGX2XqFMQSvy4kr7Vx2AiizyqfllIOg6uLfjUqnBJb e1Nk7KYMDY9wX6xbDpt+aTm1ktjPprxlmtAVz9xXpbiv0pRuk2855Pub7P8WxRU90F7o smkg== X-Gm-Message-State: APjAAAWqH7S08bRtkKshf/PWxbQWKZTuXK+fB3kCo0mMTC9yHTkjY1r1 0z/PdB1ctioypAuxHSThgQuIirne/UzWoLiIghcjVe/I X-Google-Smtp-Source: APXvYqwju0Od3bSJY6X5SrX+Gna0YnfEIT3Jq/mx8dOEEwUm1KhBlm6AeikBu+0KF09pK9ozciNB8iw1aHWNnZEoiNE= X-Received: by 2002:a2e:898b:: with SMTP id c11mr25012765lji.241.1563454129048; Thu, 18 Jul 2019 05:48:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Lilja Date: Thu, 18 Jul 2019 14:48:38 +0200 Message-ID: Subject: Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0) To: Maven Developers List Content-Type: multipart/alternative; boundary="000000000000fc1149058df40768" --000000000000fc1149058df40768 Content-Type: text/plain; charset="UTF-8" Ah, thanks Vladimir, that's even better. I was not 100% sure it would be possible to retain complete control over resulting line endings for those files, regardless of user git settings of stuff like autocrlf = true and whatnot, but it seems there is, that's great news. Thanks! - Eric L On Thu, Jul 18, 2019 at 2:00 PM Vladimir Sitnikov < sitnikov.vladimir@gmail.com> wrote: > Eric>In that case, we should generate the test files (to > Eric>avoid git interfering), one with linux-style EOLs and one with > Eric>Windows-style EOLs and test with both. > > You'd better have those files under Git control, and you could just specify > .gitattributes so the LF file is always LF, and CRLF file is always CRLF. > > That is way simpler than generation of the file(s), and it is way easier to > understand by humans > > Vladimir > --000000000000fc1149058df40768--