From dev-return-128598-archive-asf-public=cust-asf.ponee.io@maven.apache.org Mon Jul 15 19:20:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AD439180595 for ; Mon, 15 Jul 2019 21:20:26 +0200 (CEST) Received: (qmail 36050 invoked by uid 500); 15 Jul 2019 19:20:25 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 36038 invoked by uid 99); 15 Jul 2019 19:20:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jul 2019 19:20:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3D46BC07D5 for ; Mon, 15 Jul 2019 19:20:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.899 X-Spam-Level: X-Spam-Status: No, score=-0.899 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=quoss.de Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4lYZpbak6hlX for ; Mon, 15 Jul 2019 19:20:22 +0000 (UTC) Received-SPF: Pass (helo) identity=helo; client-ip=2a01:238:20a:202:5300::4; helo=mo6-p00-ob.smtp.rzone.de; envelope-from=clemens@quoss.de; receiver= Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::4]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 85F817E20D for ; Mon, 15 Jul 2019 19:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1563218415; s=strato-dkim-0002; d=quoss.de; h=In-Reply-To:Date:Message-ID:From:References:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=E/0jTzoMdLjbA4LUPxVrThuAoTEAUPY791QOBSGeVX4=; b=njO6qtSxfLVIy97C/M6UNQziF6FCoO+w/ZGiQkPrVecWQ4RoP6Oa648nFC93DuDoQw CHpLCX/U6HP/sle0w/QCz3cWFE5Flb3Fn+V6kOWzJC7owsigzrqEl/LsuoBookbc2/CC 5IKZcmm6Q6Zb2nCONrkGps6RFLEvhfEJ1UJMITAjpibwB5jhzXl5u7w6iXrH7zXD0vNA hIKEpsGkiZkXmt1T4uUwJmfbjJ51QrTUYa5YA7g80efq5HCxakRmwCsXpt6HNbaMOBJf VKqvHkAJ6ox552gYrvtKBvA+zHsRY+NdX/JN0uA7u4+9jFyQOctRHenf71Oas0mPyp5P qKwA== X-RZG-AUTH: ":L2ABeEWmaN/ljEIIhHFfSg9lAqsHWj8JFLmvj5xMut7eG9x0G0/CJUWlk21DQDdMDxGEmtMnAK0jm4I+PqBaSYo9rIjuDW1atqI=" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2003:c6:1712:de00:840c:321b:f7be:4ca8] by smtp.strato.de (RZmta 44.24 AUTH) with ESMTPSA id j0ae23v6FJKFwRs (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Mon, 15 Jul 2019 21:20:15 +0200 (CEST) Subject: Re: Naming of ITs in maven-release To: Maven Developers List , Olivier Lamy References: <6e27d7bc-dab7-e6f0-bf70-de80aede596e@quoss.de> From: Clemens Quoss Message-ID: <6c4f865d-91e8-3b95-3f63-9a8961ea5821@quoss.de> Date: Mon, 15 Jul 2019 21:20:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hi Olivier, yeah, could do that.  Would be a great idea.  But i am stuck on what to put into this IT: RemoveScmTag does what the name suggests:  it uses maven-scm to remove the tag during release:rollback. In the unit tests maven-scm is mocked away and i think in the ITs of maven-release maven-scm is out of scope, too. Then there is not really much left to test there. Maybe someone out there has a different opinion?  And we can discuss this further in private mail? TIA Clemens Am 15.07.2019 um 02:12 schrieb Olivier Lamy: > Hi > I agree the name is a bit confusing... > maybe name the IT: MRELEASE-229-RemoveScmTagPhase? > > > On Sun, 14 Jul 2019 at 20:06, Clemens Quoss wrote: > >> Hello everyone, >> >> one more question regarding the name of the ITs in maven-release (or >> maybe generally): >> >> Seeing that the tests are named after the jira issues i am wondering if >> that would be the right thing to do. >> >> Shouldn't they be named after the functionality they are testing? >> >> I for my part, being new to the whole thing, have provided a PR for >> MRELEASE-229 (implementing RemoveScmTagPhase with some unit tests) [1]. >> >> Now i would like to see if there are IT for ScmTagPhase to help me in my >> orientation. >> >> For goal prepare there seem to exist the following: >> >> ... >> >> 10.07.2019 08:16 completion-goals >> 17.02.2019 23:40 flat-multi-module >> 10.07.2019 08:16 forked-basic >> 10.07.2019 08:16 invoker-basic >> 10.07.2019 08:16 833 invoker.properties >> 10.07.2019 08:15 MRELEASE-128 >> 10.07.2019 08:15 MRELEASE-156 >> 10.07.2019 08:15 MRELEASE-161 >> 10.07.2019 08:15 MRELEASE-161-dependencyManagement >> 10.07.2019 08:15 MRELEASE-420 >> 10.07.2019 08:15 MRELEASE-483 >> 10.07.2019 08:15 MRELEASE-533 >> 10.07.2019 08:15 MRELEASE-571_M3 >> 10.07.2019 08:16 MRELEASE-618 >> 10.07.2019 08:16 MRELEASE-667 >> 17.02.2019 23:40 MRELEASE-834 >> 10.07.2019 08:16 MRELEASE-966 >> 10.07.2019 08:16 MRELEASE-976 >> 10.07.2019 08:16 regular-multi-module >> >> ... >> >> Maybe one of the MRELEASE-... ITs does something with ScmTagPhase, maybe >> not. I will have to look into everyone of them to decide. >> >> Would there be a test or tests named 'scm-tag-phase' or >> 'scm-tag-phase-MRELEASE-...' this would be of help, at least to me. >> >> Or have I misunderstood some fundamental concept here? >> >> Regards, >> >> Clemens >> >> [1] https://github.com/apache/maven-release/pull/29 >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >> For additional commands, e-mail: dev-help@maven.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org