From dev-return-128006-archive-asf-public=cust-asf.ponee.io@maven.apache.org Tue Apr 23 17:29:58 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AD87B18076D for ; Tue, 23 Apr 2019 19:29:57 +0200 (CEST) Received: (qmail 9689 invoked by uid 500); 23 Apr 2019 17:29:56 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 9632 invoked by uid 99); 23 Apr 2019 17:29:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Apr 2019 17:29:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 88EAFC28E2 for ; Tue, 23 Apr 2019 17:29:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.701 X-Spam-Level: X-Spam-Status: No, score=-0.701 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=gmx.net Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id fojFmZ8-xW0R for ; Tue, 23 Apr 2019 17:29:50 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id EBC5160E83 for ; Tue, 23 Apr 2019 17:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556040582; bh=3tzEoHq7JtBo08NPRxqXSssTXJVyBCk+EHbNh6vb6Wo=; h=X-UI-Sender-Class:Reply-To:Subject:To:References:From:Date: In-Reply-To; b=j5cZLdIkr+G6PGDnD4envk4F+JZbBc2QUxHjsUb2k+tJbp6KIp/TtZXcf0hU4gnlS eUgnoiL0fEDoRLLED9h+XG6Zg/gSi/dZhwvh8XNxH2P+c8iOJmUJW9lSpTjYN3/o+R mbsSKsR7VbhNQ1p3IUUO1tI3CtyNcRZ7uo2jYPCE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from khmac.local ([92.201.42.155]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MfSrf-1hT68j2f3D-00P5Ju; Tue, 23 Apr 2019 19:29:42 +0200 Reply-To: info@soebes.de Subject: Re: Bumping Checkstyle plugin version to 3.1.0-SNAPSHOT (from 3.0.1-SNAPSHOT) To: Maven Developers List , Enrico Olivelli References: From: Karl Heinz Marbaise Message-ID: <5221e2e6-8753-df9e-4d6f-a31a424a40ba@gmx.de> Date: Tue, 23 Apr 2019 19:29:37 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Dsk0YyuGdWMn/OGL92YsujxucfI2Iai65SL5IMJoeeus+hQpw74 hCWRaGLFpZGSDUXG2hf1Ux2w5xBRS030jLVT7bNm89wCAZqjw4JGFOWpLK6s0WMnuVVujyN dFz+v83NUgnxwPDx85PUyxnf0JNW9h1PaHajKkv6zyvDViks93sbWpPZHToOLiOpD7W2FAm liCCqKlsgy2AAmuo/jAdQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:PNEFH2VGAbw=:LpVUBx3ZEAQSr/XEddd1FR zKrgECqQMSL54WztB88CxBWeKHyLYZ9LTVMrHdwcDGhbQsLce20OWyVHYFj/wgqqd0PF7Uuf+ u09lUeSvRDHz8UDOEI+gRnQv5C99XqvkMB/9w3FAnM2nw7TI7NWhsj93KP13jDqltUEFhk+Wd H1HMHCffhR5YbWlNp6QYaE9C5DrH+TdQxUE2GD2Hv0JFr7MrqpKid4HK5e9bma8TV++h28OYW Y/TNjPFS3p/bLNV+5wqpB5t7kBIY+ldyGqXst9f+xLAuXhSJcpPEcIfxeCbFbKXvXAyStVB4Z tj6n5IsofU7GRSfhCyKdgclEowxo3g2wcwcMC7nnUFG8o42PGnVL+Yv1V14189bjwbcEWH1te O8ZHueSkG11ACU41MS5QERZkoRIsnMZqZKfzbJ8xBCxqnTzPBT/HMh2EaW89yV0bi8nhT6MzU tzuYgiZcVZMffldXNqPl2rGcyv48cS3qrCNtxocwwX3fEsf7LhAzXl9Z+BBbUY5XQIGfz1GqZ CnYrAGhG31LJSULMhiGoeL0hYhxbtKp9QYdZTWTpjsMpHyaLQ2/oxJWWEP/Q5dN15MNUQB/Kb CoOnrQnR5FIRIBY5RPjMZg9L4NqsZBnpVnB7HxT3ub0PRS3FawLuPkdQa3Y1AA71T2/ucSd30 gEBIogSaYI0Sb4UYSbUYqHiuITow6msUw0XO5R1XQeF+KiHF+205YfVxVR1nBtH4j+7GfAsq3 aFS6qDFh1v98Ej2e/oz8XkUiN3BbjED9t+EM3L6WmRIbbRxT92UrN+5SPyT/4oSHEQAm4+V1p PgrhoalrqO1k0gcLJ5GsjcXOJ2SAQ+FqVtoFhaYL1RBKQqdPqkddWukutkVj6/7XiZUeQskk1 k9ALlX24FESsDICV72EICVurJ1fWmhP330MaO9MaLiDCFKpizTRAEIGiD6cuoa+NMLYLZQSJ5 JNZ3BM7mKqg== Hi Enrico, Done so. Kind regards Karl Heinz Marbaise On 23.04.19 00:26, Enrico Olivelli wrote: > Committed. > Can any JIRA admin rename version 3.0.1 to 3.1.0 please ? > > Thanks > Enrico > > Il dom 21 apr 2019, 21:07 Stephen Connolly > ha scritto: > >> On Sun 21 Apr 2019 at 16:24, Enrico Olivelli wrot= e: >> >>> Hi, >>> I want to commit this breaking change [1] in checkstyle plugin, >>> that is the upgrade [2] to latest checkstyle (8.x) and thus the making >>> Java 8 the minimum version for the plugin. >>> >>> Currently I have 3.0.1-SNAPSHOT on master, >>> I think I need to move to 3.1.0-SNAPSHOT. >> >> >> +1 >> >> >>> >>> Is is better to bump the version to 3.1.0-SNAPSHOT and then commit the >>> breaking change or commit the change and then commit the new version ? >>> >>> I feel it is better to change the version to 3.1.0-SNAPSHOT and then >>> commit the breaking change. >>> >>> Any review on the PR is well appreciated as well >>> >>> Best regards and Happy Easter ! >>> Enrico >>> >>> [1] https://github.com/apache/maven-checkstyle-plugin/pull/13 >>> [2] https://issues.apache.org/jira/browse/MCHECKSTYLE-366 >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >>> For additional commands, e-mail: dev-help@maven.apache.org >>> >>> -- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org