maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Karl Heinz Marbaise <khmarba...@gmx.de>
Subject Re: Bumping Checkstyle plugin version to 3.1.0-SNAPSHOT (from 3.0.1-SNAPSHOT)
Date Tue, 23 Apr 2019 17:29:37 GMT
Hi Enrico,

Done so.

Kind regards
Karl Heinz Marbaise

On 23.04.19 00:26, Enrico Olivelli wrote:
> Committed.
> Can any JIRA admin rename version 3.0.1 to 3.1.0 please ?
>
> Thanks
> Enrico
>
> Il dom 21 apr 2019, 21:07 Stephen Connolly <stephen.alan.connolly@gmail.com>
> ha scritto:
>
>> On Sun 21 Apr 2019 at 16:24, Enrico Olivelli <eolivelli@gmail.com> wrote:
>>
>>> Hi,
>>> I want to commit this breaking change [1] in checkstyle plugin,
>>> that is the upgrade [2] to latest checkstyle (8.x) and thus the making
>>> Java 8 the minimum version for the plugin.
>>>
>>> Currently I have 3.0.1-SNAPSHOT on master,
>>> I think I need to move to 3.1.0-SNAPSHOT.
>>
>>
>> +1
>>
>>
>>>
>>> Is is better to bump the version to 3.1.0-SNAPSHOT and then commit the
>>> breaking change or commit the change and then commit the new version ?
>>>
>>> I feel it is better to change the version to 3.1.0-SNAPSHOT and then
>>> commit the breaking change.
>>>
>>> Any review on the PR is well appreciated as well
>>>
>>> Best regards and Happy Easter !
>>> Enrico
>>>
>>> [1] https://github.com/apache/maven-checkstyle-plugin/pull/13
>>> [2] https://issues.apache.org/jira/browse/MCHECKSTYLE-366
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>> --

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message