From dev-return-127080-archive-asf-public=cust-asf.ponee.io@maven.apache.org Tue Nov 20 20:01:36 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6D9AA18064E for ; Tue, 20 Nov 2018 20:01:35 +0100 (CET) Received: (qmail 39553 invoked by uid 500); 20 Nov 2018 19:01:34 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 39541 invoked by uid 99); 20 Nov 2018 19:01:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Nov 2018 19:01:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 63CFBD0F4B for ; Tue, 20 Nov 2018 19:01:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.341 X-Spam-Level: X-Spam-Status: No, score=0.341 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id pv9s-5LKtTiu for ; Tue, 20 Nov 2018 19:01:32 +0000 (UTC) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7ED545F536 for ; Tue, 20 Nov 2018 19:01:31 +0000 (UTC) Received: by mail-ot1-f54.google.com with SMTP id u3so2670986ota.5 for ; Tue, 20 Nov 2018 11:01:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=84S794jCbkuoUjiRSxVt2dcIHR7UekFZp4vXAgbj6C4=; b=PZB7nZUjMYjKetdEP7ZinYTwGgv2klnGFyn85rsIU6KwP30eFAexcgzLXuff9hVwQV A6xU2OXgXj+SIQGnvU8+p/RQS47wbR5oLCxkb77teNZJdwKFlRpMeGvptQZATWeQJIuc 1iLjoAc41M9KCRQtDAunO8JHD6zkQCPQvl3MtPqWGtBCCG0iR1xLzS3GcVuIsbGhxAhZ j3BMIaIwv2xGaPTSxDEtsmv20aLMQAusMOFNBS7Rb38EMcLPshzkDKhdBeDDnVqVYqWc +b9ISIUGTctDfPP+iT+FJzsdUcW1SR+R/oDv3uX32gKlLRoAYg4IQLv21+iYtE1L6QI3 R41Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=84S794jCbkuoUjiRSxVt2dcIHR7UekFZp4vXAgbj6C4=; b=TVnVZ/yoLePdC50q88NUJMwHe/xxHLSb8izFrIFuy//6S+WlCHIoJARTXXoi1E1KCS cyCO+0eclpQ8SdFan76Zt2T08BiUTFCoRaD0nT/jWS+CzfzdaIlPxibpJsimUDgMNRHO xja1KR22csFR2UG/at4fqsIlqYRo2aH1JfyWpjyXebmziDVoM9gL4pCSX54TklNajooJ X+ojBsUHuqO7nqD91A6cC8Wcgq5KBy13uq4WJz7v15WA73WcuEqNb7/wi+4QymXwJvuO cLHHGjPRnKLw100knhOvlHjJl+MYifqhpzAlId3X9m1JUlfM4zNdxYQ4OC7pp2jbhktG 2XlA== X-Gm-Message-State: AA+aEWZ2vvC6wX58HMUwWrI4pIgZ1H2QLnZ+AnEa/w9O0XmUS34kVnH1 PLD3pxbGixxWxrb+/gwHEuV2bp+435o31h8lv7xDjA== X-Google-Smtp-Source: AFSGD/WtPSaIIWyWO6EqMJAZXBjcIAMmowMF7ELs3KHVewWppLQCsZoXS32Pxh2ZFrJT0Er4hRB6tw+mb67Nyg0GwDA= X-Received: by 2002:a9d:245:: with SMTP id 63mr1834009otb.135.1542740489900; Tue, 20 Nov 2018 11:01:29 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Romain Manni-Bucau Date: Tue, 20 Nov 2018 20:01:16 +0100 Message-ID: Subject: Re: Extension does not work from .mvn/extensions.xml To: Maven Developers List Content-Type: multipart/alternative; boundary="000000000000e196fa057b1d426e" --000000000000e196fa057b1d426e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le mar. 20 nov. 2018 19:23, J. Lewis Muir a =C3=A9cri= t : > On Tue, Nov 20, 2018 at 2:30 AM Romain Manni-Bucau > wrote: > > 1. you have to use lib/ext folder and not extensions.xml cause it is > loaded > > too late > > Unfortunately, that's a deal breaker. Using Maven's lib/ext is the > original situation I reported when I started this thread (i.e., it > worked from Maven's lib/ext, but not from the project's > .mvn/extensions.xml.) There's no way I can get the developers of the > software I'm planning to use this in to install the extension in > Maven's lib/ext; it has to be able to work from the project's > .mvn/extensions.xml. I guess this is the end of the road, then. > Bummer. > Even with mvnsh, maven opts or the -D? > > 2. you have to override the property activator as you mentionned cause > > otherwise your profile is added (through plexus) in the list of > activator, > > set the activation to true and then property one sets it to false > > > > To do 2 you just have to use sisu @Priority and ensure the hint is > property: > > I tried adding the Priority annotation, and it works from Maven's > lib/ext, but it also works *without* it, so I'm hesitant to add it > unless I know it's really necessary. The readme file in Maven's > lib/ext says > Without it you dont deactivate default one - you can check it debugging it. > Use this directory to contribute 3rd-party extensions to the Maven > core. These extensions can either extend or override Maven's default > implementation. > > Do I really need the Priority annotation, or will my extension's > AdvancedProfileActivator (annotated with '@Component(role =3D > ProfileActivator.class, hint =3D "property")') always take precedence > over the default by virtue of being in Maven's lib/ext? > This kind of order is fragile so better to be deterministic ans more robust imho > Thank you! > > Lewis > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org > For additional commands, e-mail: dev-help@maven.apache.org > > --000000000000e196fa057b1d426e--