maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yuri de Wit <yde...@gmail.com>
Subject Re: [ANN] Apache Maven Shade Plugin Version 3.2.0 Released
Date Wed, 10 Oct 2018 21:10:57 GMT
Even without the <extensions>true</extensions> maven-shade-plugin fails
with the same error:

Here is the result of running mvn help:resolve-plugins -pl module/:

[INFO] Plugin Resolved: maven-shade-plugin-3.2.0.jar
> [INFO]     Plugin Dependency Resolved: maven-plugin-api-3.0.jar
> [INFO]     Plugin Dependency Resolved: maven-model-3.0.jar
> [INFO]     Plugin Dependency Resolved: maven-core-3.0.jar
> [INFO]     Plugin Dependency Resolved: maven-artifact-3.0.jar
> [INFO]     Plugin Dependency Resolved: plexus-utils-3.1.0.jar
> [INFO]     Plugin Dependency Resolved: maven-artifact-transfer-0.10.0.jar
>
>
> *[INFO]     Plugin Dependency Resolved: asm-6.2.1.jar[INFO]     Plugin
> Dependency Resolved: asm-commons-6.2.1.jar*[INFO]     Plugin Dependency
> Resolved: jdom2-2.0.6.jar
> [INFO]     Plugin Dependency Resolved: maven-dependency-tree-2.2.jar
> [INFO]     Plugin Dependency Resolved: commons-io-2.5.jar
> [INFO]     Plugin Dependency Resolved: jdependency-2.0.jar
> [INFO]     Plugin Dependency Resolved: guava-19.0.jar


On Wed, Oct 10, 2018 at 6:05 PM Yuri de Wit <ydewit@gmail.com> wrote:

> We use the org.springframework.build:aws-maven extension to deploy our
> artifacts directly to S3 and we have had issues where some plugins would
> not find the S3 wagon. So we ended up adding to all plugins: we just want
> all plugins to use the aws-maven S3 wagon at all times.
>
> I am happy to try and what happens although I am not sure why would
> enabling extensions change the dependency resolution mechanism.
>
>
>
>
> On Wed, Oct 10, 2018 at 5:12 PM Enrico Olivelli <eolivelli@gmail.com>
> wrote:
>
>> Il mer 10 ott 2018, 21:44 Yuri de Wit <ydewit@gmail.com> ha scritto:
>>
>> > Here it is:
>> >
>> > parent/pom.xml (independent parent pom):
>> >                 <plugin>
>> >                     <groupId>org.apache.maven.plugins</groupId>
>> >                  <artifactId>maven-shade-plugin</artifactId>
>> >                     <version>3.2.0</version>
>> >                     <extensions>true</extensions>
>> >
>>
>> Why extensions? I think you can drop this tag
>>
>> Enrico
>>
>>                     <dependencies>
>> >                         <dependency>
>> >                             <groupId>org.ow2.asm</groupId>
>> >                             <artifactId>asm</artifactId>
>> >                             <version>7.0-beta</version>
>> >                         </dependency>
>> >                     </dependencies>
>> >                 </plugin>
>> >
>> > root/pom.xml (aggregate):
>> > (no shade-plugin entry)
>> >
>> > root/module/pom.xml (module with root/pom.xml as parent):
>> >             <plugin>
>> >                 <groupId>org.apache.maven.plugins</groupId>
>> >                 <artifactId>maven-shade-plugin</artifactId>
>> >                 <configuration>
>> >                     <artifactSet>
>> >                         <includes>
>> >                             <include>com.google.collections:*</include>
>> >                             <include>com.google.gdata:*</include>
>> >                         </includes>
>> >                     </artifactSet>
>> >                     <relocations>
>> >                         <relocation>
>> >                             <pattern>com.google.common</pattern>
>> >                             <shadedPattern>shaded.com.google.common
>> > </shadedPattern>
>> >                         </relocation>
>> >                     </relocations>
>> >                 </configuration>
>> >                 <executions>
>> >                     <execution>
>> >                         <phase>package</phase>
>> >                         <goals>
>> >                             <goal>shade</goal>
>> >                         </goals>
>> >                     </execution>
>> >                 </executions>
>> >             </plugin>
>> >
>> > On Wed, Oct 10, 2018 at 4:34 PM Enrico Olivelli <eolivelli@gmail.com>
>> > wrote:
>> >
>> > > Il mer 10 ott 2018, 21:07 Yuri de Wit <ydewit@gmail.com> ha scritto:
>> > >
>> > > > Hi Enrico,
>> > > >
>> > > > I tried, but I could not get the dependency upgraded. I don't know
>> > why. I
>> > > > even tried setting the asmVersion property but without luck.
>> > > > thanks,
>> > > >
>> > >
>> > > Can you share your plugin config?
>> > > Enrico
>> > >
>> > > >
>> > > > On Wed, Oct 10, 2018 at 2:01 PM Enrico Olivelli <
>> eolivelli@gmail.com>
>> > > > wrote:
>> > > >
>> > > > > You can override the dependency on asm inside the plugin
>> > configuration
>> > > if
>> > > > > it is only a matter for upgrade
>> > > > > This should work and unblock you
>> > > > > Enrico
>> > > > >
>> > > > > Il mer 10 ott 2018, 16:17 Yuri de Wit <ydewit@gmail.com>
ha
>> scritto:
>> > > > >
>> > > > > > For what is worth:
>> > > > > >
>> > > > > > Caused by: java.lang.UnsupportedOperationException: This
feature
>> > > > requires
>> > > > > > ASM7
>> > > > > >     at org.objectweb.asm.ClassVisitor.visitNestHost
>> > > > > (ClassVisitor.java:150)
>> > > > > >     at org.objectweb.asm.ClassReader.accept
>> (ClassReader.java:541)
>> > > > > >     at org.objectweb.asm.ClassReader.accept
>> (ClassReader.java:391)
>> > > > > >     at
>> > org.apache.maven.plugins.shade.DefaultShader.addRemappedClass
>> > > > > > (DefaultShader.java:466)
>> > > > > >     at
>> org.apache.maven.plugins.shade.DefaultShader.shadeSingleJar
>> > > > > > (DefaultShader.java:237)
>> > > > > >     at org.apache.maven.plugins.shade.DefaultShader.shadeJars
>> > > > > > (DefaultShader.java:192)
>> > > > > >     at org.apache.maven.plugins.shade.DefaultShader.shade
>> > > > > > (DefaultShader.java:106)
>> > > > > >     at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute
>> > > > > > (ShadeMojo.java:442)
>> > > > > >     at
>> > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
>> > > > > > (DefaultBuildPluginManager.java:137)
>> > > > > >
>> > > > > >
>> > > > > > On Wed, Oct 10, 2018 at 10:33 AM Yuri de Wit <ydewit@gmail.com>
>> > > wrote:
>> > > > > >
>> > > > > > > Hi Olivier,
>> > > > > > >
>> > > > > > > Thanks for the head up!
>> > > > > > >
>> > > > > > >
>> > > > > > >
>> > > > > > > On Wed, Oct 10, 2018 at 9:16 AM Olivier Lamy <
>> olamy@apache.org>
>> > > > wrote:
>> > > > > > >
>> > > > > > >> Hi
>> > > > > > >> On my TODO for next week with pmd and maven-plugin-plugin
>> > > > > > >> Cheers
>> > > > > > >> Olivier
>> > > > > > >>
>> > > > > > >> On Wed, 10 Oct 2018 at 10:01 pm, Yuri de Wit <
>> ydewit@gmail.com>
>> > > > > wrote:
>> > > > > > >>
>> > > > > > >> > It turns out there is already a JIRA issue
for this:
>> > MSHADE-301
>> > > > > > >> > <https://issues.apache.org/jira/browse/MSHADE-301>.
And it
>> > has
>> > > > been
>> > > > > > >> fixed
>> > > > > > >> > by Olivier Lamy.
>> > > > > > >> >
>> > > > > > >> > thanks,
>> > > > > > >> >
>> > > > > > >> > On Wed, Oct 10, 2018 at 8:56 AM Yuri de Wit
<
>> ydewit@gmail.com
>> > >
>> > > > > wrote:
>> > > > > > >> >
>> > > > > > >> > > Hi Enrico,
>> > > > > > >> > >
>> > > > > > >> > > This is the error I get:
>> > > > > > >> > >
>> > > > > > >> > > org.apache.maven.plugin.MojoExecutionException:
Error in
>> ASM
>> > > > > > >> processing
>> > > > > > >> > > class org/test/A/ext/StateExtension.class:
This feature
>> > > requires
>> > > > > > ASM7
>> > > > > > >> ->
>> > > > > > >> > > [Help 1]
>> > > > > > >> > >
>> > > > > > >> > > My understanding is that asm version
6.2.1 doesn't
>> support
>> > > Java
>> > > > 11
>> > > > > > >> nested
>> > > > > > >> > > classes unless the ASM7 is explicitly
enabled from the
>> API.
>> > > The
>> > > > > > >> version
>> > > > > > >> > > 7.0+ does seem to make ASM7 the default,
but so far only
>> a
>> > > > > 7.0-beta
>> > > > > > >> asm
>> > > > > > >> > > release.
>> > > > > > >> > >
>> > > > > > >> > > thanks,
>> > > > > > >> > >
>> > > > > > >> > >
>> > > > > > >> > >
>> > > > > > >> > >
>> > > > > > >> > > On Wed, Oct 10, 2018 at 8:48 AM Enrico
Olivelli <
>> > > > > > eolivelli@gmail.com>
>> > > > > > >> > > wrote:
>> > > > > > >> > >
>> > > > > > >> > >> Il mer 10 ott 2018, 13:02 Yuri de
Wit <ydewit@gmail.com
>> >
>> > ha
>> > > > > > scritto:
>> > > > > > >> > >>
>> > > > > > >> > >> > Hi,
>> > > > > > >> > >> >
>> > > > > > >> > >> > Any plans to release 3.2.1 with
Java 11 support?
>> > > > > > >> > >> >
>> > > > > > >> > >>
>> > > > > > >> > >> I am using jdk11 with current stable
version.
>> > > > > > >> > >> Which is your problem?
>> > > > > > >> > >>
>> > > > > > >> > >> Enrico
>> > > > > > >> > >>
>> > > > > > >> > >> >
>> > > > > > >> > >> > thanks,
>> > > > > > >> > >> >
>> > > > > > >> > >> > On Wed, Sep 12, 2018 at 5:34
PM Karl Heinz Marbaise <
>> > > > > > >> > >> khmarbaise@apache.org
>> > > > > > >> > >> > >
>> > > > > > >> > >> > wrote:
>> > > > > > >> > >> >
>> > > > > > >> > >> > > The Apache Maven team is
pleased to announce the
>> > release
>> > > of
>> > > > > the
>> > > > > > >> > >> > > Apache Maven Shade Plugin
Version 3.2.0
>> > > > > > >> > >> > >
>> > > > > > >> > >> > >
>> https://maven.apache.org/plugins/maven-shade-plugin/
>> > > > > > >> > >> > >
>> > > > > > >> > >> > > Important Note since 3.2.0:
>> > > > > > >> > >> > >
>> > > > > > >> > >> > >  * Maven 3.X only
>> > > > > > >> > >> > >  * If you like to use minimizeJar
you have to use
>> JDK8+
>> > > > > > >> > >> > >    otherwise you can keep
running with JDK7.
>> > > > > > >> > >> > >
>> > > > > > >> > >> > > You should specify the
version in your project's
>> plugin
>> > > > > > >> > configuration:
>> > > > > > >> > >> > >
>> > > > > > >> > >> > > <plugin>
>> > > > > > >> > >> > >   <groupId>org.apache.maven.plugins</groupId>
>> > > > > > >> > >> > >   <artifactId>maven-shade-plugin</artifactId>
>> > > > > > >> > >> > >   <version>3.2.0</version>
>> > > > > > >> > >> > > </plugin>
>> > > > > > >> > >> > >
>> > > > > > >> > >> > > You can download the appropriate
sources etc. from
>> the
>> > > > > download
>> > > > > > >> > page:
>> > > > > > >> > >> > >
>> > > > > > >> > >> > >
>> > > > > >
>> https://maven.apache.org/plugins/maven-shade-plugin/download.cgi
>> > > > > > >> > >> > >
>> > > > > > >> > >> > > Release Notes Maven Shade
Plugin 3.2.0
>> > > > > > >> > >> > >
>> > > > > > >> > >> > >
>> > > > > > >> > >> > >
>> > > > > > >> > >> >
>> > > > > > >> > >>
>> > > > > > >> >
>> > > > > > >>
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12343491
>> > > > > > >> > >> > >
>> > > > > > >> > >> > > Bug:
>> > > > > > >> > >> > >
>> > > > > > >> > >> > >  * [MSHADE-289] - Maven
Shade Plugin does not work
>> > under
>> > > > Java
>> > > > > > 10
>> > > > > > >> > >> > >
>> > > > > > >> > >> > > Improvement:
>> > > > > > >> > >> > >
>> > > > > > >> > >> > >  * [MSHADE-293] - Require
Java 7
>> > > > > > >> > >> > >
>> > > > > > >> > >> > > Dependency upgrades:
>> > > > > > >> > >> > >
>> > > > > > >> > >> > >  * [MSHADE-294] - Upgrade
maven-plugins parent to
>> > version
>> > > > 32
>> > > > > > >> > >> > >  * [MSHADE-296] - Upgrade
maven-artifact-transfer
>> > 0.10.0
>> > > > > > >> > >> > >
>> > > > > > >> > >> > > Enjoy
>> > > > > > >> > >> > >
>> > > > > > >> > >> > > - The Apache Maven team
>> > > > > > >> > >> > >
>> > > > > > >> > >> > >
>> > > > > > >> >
>> > > > >
>> ---------------------------------------------------------------------
>> > > > > > >> > >> > > To unsubscribe, e-mail:
>> > dev-unsubscribe@maven.apache.org
>> > > > > > >> > >> > > For additional commands,
e-mail:
>> > > dev-help@maven.apache.org
>> > > > > > >> > >> > >
>> > > > > > >> > >> > >
>> > > > > > >> > >> >
>> > > > > > >> > >> --
>> > > > > > >> > >>
>> > > > > > >> > >>
>> > > > > > >> > >> -- Enrico Olivelli
>> > > > > > >> > >>
>> > > > > > >> > >
>> > > > > > >> >
>> > > > > > >> --
>> > > > > > >> Olivier Lamy
>> > > > > > >> http://twitter.com/olamy | http://linkedin.com/in/olamy
>> > > > > > >>
>> > > > > > >
>> > > > > >
>> > > > > --
>> > > > >
>> > > > >
>> > > > > -- Enrico Olivelli
>> > > > >
>> > > >
>> > > --
>> > >
>> > >
>> > > -- Enrico Olivelli
>> > >
>> >
>> --
>>
>>
>> -- Enrico Olivelli
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message