From dev-return-125976-archive-asf-public=cust-asf.ponee.io@maven.apache.org Tue May 8 21:17:41 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D6CCF18063B for ; Tue, 8 May 2018 21:17:40 +0200 (CEST) Received: (qmail 50773 invoked by uid 500); 8 May 2018 19:17:39 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 50762 invoked by uid 99); 8 May 2018 19:17:39 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 May 2018 19:17:39 +0000 Received: from desktop-2khsk44.mshome.net (5248749D.cm-4-1b.dynamic.ziggo.nl [82.72.116.157]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id A82B47BF for ; Tue, 8 May 2018 19:17:38 +0000 (UTC) Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes To: "Maven Developers List" Subject: Re: Second MNG-6403 References: <56c1897e-06cc-7ab4-08a8-1bbbceb09083@apache.org> <4bc10710-f059-e765-e014-becf8b27ae44@gmx.de> <14187fb0-42a8-9060-7282-b3a10ec06877@apache.org> <863abd09-f8eb-2d2c-2f10-787eeaa706ec@apache.org> Date: Tue, 08 May 2018 21:17:46 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Robert Scholte" Organization: Apache Software Foundation Message-ID: In-Reply-To: <863abd09-f8eb-2d2c-2f10-787eeaa706ec@apache.org> User-Agent: Opera Mail/12.18 (Win64) On Tue, 08 May 2018 00:23:22 +0200, Michael Osipov wrote: > Am 2018-05-07 um 23:35 schrieb Robert Scholte: >> On Sun, 06 May 2018 21:32:18 +0200, Karl Heinz Marbaise >> wrote: >> >>> Hi Michael, >>> >>> two things are coming into my mind: >>> >>> I stumbled over one thing which is: >>> >>> Why do we have the tests in maven-compat and not in maven-artifact ? >>> Shouldn't they be in maven-artifact instead of maven-compat ? >> +1 > > Done is subsequent commmit: > https://github.com/apache/maven/commit/9021d66e53f979b0664677b7977c650e71d51d1d > > Unit tests pass, as well as ITs. > > Are we good to merge to master? > I would say yes. > >>> >>> Furthermore if I recap the code and the tests I would think we should >>> add a test that proves that the given pattern is NOT a SNAPSHOT >>> version... >>> >>> Something like this: >>> >>> assertEquals( false, ArtifactUtils.isSnapshot( >>> "1.2.3-20090413X094722-2")); >>> >>> WDYT ? >>> >>> Kind regards >>> Karl Heinz Marbaise >>> >>> >>> >>> On 06/05/18 21:15, Michael Osipov wrote: >>>> Am 2018-05-06 um 21:08 schrieb Karl Heinz Marbaise: >>>>> Hi, >>>>> >>>>> I second MNG-6403 for 3.5.4 we should write a test for this to be >>>>> sure this does not happen again... >>>> Do you have anything specific in mind? >>>> I have updated the branch and added a test to ArtifactUtilsTest. Is >>>> that sufficient? >>>> Michael >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >>> For additional commands, e-mail: dev-help@maven.apache.org >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >> For additional commands, e-mail: dev-help@maven.apache.org >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org > For additional commands, e-mail: dev-help@maven.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org