maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Osipov <micha...@apache.org>
Subject Re: Second MNG-6386
Date Tue, 01 May 2018 21:22:59 GMT
Am 2018-05-01 um 19:40 schrieb Robert Scholte:
> Hi Michael,
> 
> to me it looks like the tests don't proof there's an issue.
> 
> I only see that testDir.toURI() being replaced with 
> testDir.toPath().toUri() while the actual value stays the same.

No, it doesn't on Windows. File#toURI() is broken. Please see the issue 
description.

The current behavior will give with SCM:
PS D:\Entwicklung\Projekte\maven-scm> svn ls 
file:/D:/Entwicklung/svn-repos/scm-svn-test-at-sign
svn: E020024: Error resolving case of 
'file:\D:\Entwicklung\svn-repos\scm-svn-test-at-sign'

while the proper (new) havior will produce a valid URI:
PS D:\Entwicklung\Projekte\maven-scm> svn ls 
file:///D:/Entwicklung/svn-repos/scm-svn-test-at-sign
branches/
tags/
trunk/

See also [1] and [2] on the wrong implementation of File#toURI().

> I would expect at least one new test that fails now, but will succeed 
> with the change.

That's right. I have added a test, it should fail on Windows. Before 
merging back to trunk, I'd adapt for Windows and Unix-like.

Michael

[1] https://stackoverflow.com/a/17870390/696632
[2] https://blogs.msdn.microsoft.com/ie/2006/12/06/file-uris-in-windows/

> On Tue, 01 May 2018 13:07:22 +0200, Michael Osipov <michaelo@apache.org> 
> wrote:
> 
>> Folks,
>>
>> who seconds MNG-6386 for 3.5.4 which I have found during SCM-877.
>> ${project.baseUri} is an invalid URL. NIO2 offers a solution for that.
>>
>> Michael
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message