maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dan Tran <dant...@gmail.com>
Subject Re: [VOTE] Release Apache Maven 3.5.3
Date Tue, 27 Feb 2018 18:01:33 GMT
Hi all,

I believe my usage of antrun is legit to make sure user who is using  mvn
install ( without clean) has a proper clean up before another plugin
execution

      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-antrun-plugin</artifactId>
        <executions>
          <execution>
            <id>work.around.to.clean.up.classes.before.jsonschema.start</id>
            <phase>generate-sources</phase>
            <goals>
              <goal>run</goal>
            </goals>
            <configuration>
              <target>
                <delete dir="${project.build.directory}/classes" />
              </target>
            </configuration>
          </execution>
        </executions>
      </plugin>


here is the command to reproduce the antrun issue


      mvn clean install --builder smart -T1.0C -DskipTests


Add  -B to remove the issue but it is not ideal

Only only happens on windows ( i only test with windows and linux)

-D



On Tue, Feb 27, 2018 at 7:44 AM, Stephen Connolly <
stephen.alan.connolly@gmail.com> wrote:

> On 27 February 2018 at 14:46, Mirko Friedenhagen <mfriedenhagen@gmail.com>
> wrote:
>
> > +1 from my side, tested with 10 inhouse projects. Or is this vote
> canceled?
> >
>
> Not cancelled yet. Unclear if Dan's issue is something forking maven and
> parsing the output... the task name
> "work.around.to.clean.up.classes.before.jsonschema.start" sounds like it
> could be doing something crazy like that, in which case it is not using -B
> when forking maven in Dan's codebase that could be the root cause.
>
>
> > Regards Mirko
> > --
> > http://illegalstateexception.blogspot.com/
> > https://github.com/mfriedenhagen/
> > https://bitbucket.org/mfriedenhagen/
> >
> >
> > On Sun, Feb 25, 2018 at 10:14 AM, Dan Tran <dantran@gmail.com> wrote:
> > >   correction
> > >
> > > found this reference, found on 3.5.2 but I only encounter this on 3.5.3
> > RC
> > >
> > > https://stackoverflow.com/questions/48723899/maven-
> > > numberformatexception-when-packaging
> > >
> > >
> > > On Sun, Feb 25, 2018 at 1:13 AM, Dan Tran <dantran@gmail.com> wrote:
> > >
> > >> found this reference, found on 3.5.2 but I only encounter this on
> 3.5.2
> > RC
> > >>
> > >> https://stackoverflow.com/questions/48723899/maven-
> > >> numberformatexception-when-packaging
> > >>
> > >> On Sun, Feb 25, 2018 at 12:53 AM, Dan Tran <dantran@gmail.com> wrote:
> > >>
> > >>> my build contains 270+ modules using java 8.  The failure found on
> > >>> windows. Have not tested on Linux  yet
> > >>>
> > >>> -D
> > >>>
> > >>> On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran <dantran@gmail.com>
> wrote:
> > >>>
> > >>>> Encounter random failure at antrun MOJO + smart builder
> > >>>>
> > >>>> here is the error message
> > >>>>
> > >>>> [ERROR] Failed to execute goal org.apache.maven.plugins:
> > maven-antrun-plugin:1.8:run
> > >>>> (work.around.to.clean.up.classes.before.jsonschema.start) on
> project
> > >>>> adm-schema: Error executing Ant tasks: For input string: "1;" ->
> > [Help 1]
> > >>>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed
to
> > >>>> execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> > >>>> (work.around.to.clean.up.classes.before.jsonschema.start) on
> project
> > >>>> adm-schema: Error executing Ant tasks: For input string: "1;"
> > >>>>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> > >>>> (MojoExecutor.java:213)
> > >>>>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> > >>>> (MojoExecutor.java:154)
> > >>>>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> > >>>> (MojoExecutor.java:146)
> > >>>>     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
> > buildProject
> > >>>> (LifecycleModuleBuilder.java:117)
> > >>>>     at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
> > >>>> (SmartBuilderImpl.java:205)
> > >>>>     at io.takari.maven.builder.smart.SmartBuilderImpl$
> > ProjectBuildTask.run
> > >>>> (SmartBuilderImpl.java:77)
> > >>>>     at java.util.concurrent.Executors$RunnableAdapter.call
> > >>>> (Executors.java:511)
> > >>>>     at java.util.concurrent.FutureTask.run (FutureTask.java:266)
> > >>>>     at java.util.concurrent.ThreadPoolExecutor.runWorker
> > >>>> (ThreadPoolExecutor.java:1149)
> > >>>>     at java.util.concurrent.ThreadPoolExecutor$Worker.run
> > >>>> (ThreadPoolExecutor.java:624)
> > >>>>     at java.lang.Thread.run (Thread.java:748)
> > >>>> Caused by: org.apache.maven.plugin.MojoExecutionException: Error
> > >>>> executing Ant tasks: For input string: "1;"
> > >>>>     at org.apache.maven.plugin.antrun.AntRunMojo.execute
> > >>>> (AntRunMojo.java:347)
> > >>>>     at org.apache.maven.plugin.DefaultBuildPluginManager.
> executeMojo
> > >>>> (DefaultBuildPluginManager.java:137)
> > >>>>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> > >>>> (MojoExecutor.java:208)
> > >>>>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> > >>>> (MojoExecutor.java:154)
> > >>>>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> > >>>> (MojoExecutor.java:146)
> > >>>>     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
> > buildProject
> > >>>> (LifecycleModuleBuilder.java:117)
> > >>>>     at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
> > >>>> (SmartBuilderImpl.java:205)
> > >>>>     at io.takari.maven.builder.smart.SmartBuilderImpl$
> > ProjectBuildTask.run
> > >>>> (SmartBuilderImpl.java:77)
> > >>>>     at java.util.concurrent.Executors$RunnableAdapter.call
> > >>>> (Executors.java:511)
> > >>>>     at java.util.concurrent.FutureTask.run (FutureTask.java:266)
> > >>>>     at java.util.concurrent.ThreadPoolExecutor.runWorker
> > >>>> (ThreadPoolExecutor.java:1149)
> > >>>>     at java.util.concurrent.ThreadPoolExecutor$Worker.run
> > >>>> (ThreadPoolExecutor.java:624)
> > >>>>     at java.lang.Thread.run (Thread.java:748)
> > >>>> Caused by: java.lang.NumberFormatException: For input string: "1;"
> > >>>>     at java.lang.NumberFormatException.forInputString
> > >>>> (NumberFormatException.java:65)
> > >>>>     at java.lang.Integer.parseInt (Integer.java:580)
> > >>>>     at java.lang.Integer.<init> (Integer.java:867)
> > >>>>     at org.fusesource.jansi.AnsiPrintStream.filter
> > >>>> (AnsiPrintStream.java:129)
> > >>>>     at org.fusesource.jansi.FilterPrintStream.write
> > >>>> (FilterPrintStream.java:59)
> > >>>>     at org.fusesource.jansi.FilterPrintStream.write
> > >>>> (FilterPrintStream.java:70)
> > >>>>     at java.io.PrintStream.write (PrintStream.java:480)
> > >>>>     at sun.nio.cs.StreamEncoder.writeBytes (StreamEncoder.java:221)
> > >>>>     at sun.nio.cs.StreamEncoder.implFlushBuffer
> > (StreamEncoder.java:291)
> > >>>>     at sun.nio.cs.StreamEncoder.flushBuffer
> (StreamEncoder.java:104)
> > >>>>     at java.io.OutputStreamWriter.flushBuffer
> > >>>> (OutputStreamWriter.java:185)
> > >>>>     at java.io.PrintStream.newLine (PrintStream.java:546)
> > >>>>     at java.io.PrintStream.println (PrintStream.java:807)
> > >>>>     at org.apache.tools.ant.DefaultLogger.printMessage
> > >>>> (DefaultLogger.java:346)
> > >>>>     at org.apache.tools.ant.DefaultLogger.targetStarted
> > >>>> (DefaultLogger.java:218)
> > >>>>     at org.apache.tools.ant.Project.fireTargetStarted
> > >>>> (Project.java:2140)
> > >>>>     at org.apache.tools.ant.Target.performTasks (Target.java:454)
> > >>>>     at org.apache.tools.ant.Project.executeSortedTargets
> > >>>> (Project.java:1393)
> > >>>>     at org.apache.tools.ant.Project.executeTarget
> (Project.java:1364)
> > >>>>     at org.apache.maven.plugin.antrun.AntRunMojo.execute
> > >>>> (AntRunMojo.java:313)
> > >>>>     at org.apache.maven.plugin.DefaultBuildPluginManager.
> executeMojo
> > >>>> (DefaultBuildPluginManager.java:137)
> > >>>>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> > >>>> (MojoExecutor.java:208)
> > >>>>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> > >>>> (MojoExecutor.java:154)
> > >>>>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> > >>>> (MojoExecutor.java:146)
> > >>>>     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
> > buildProject
> > >>>> (LifecycleModuleBuilder.java:117)
> > >>>>     at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
> > >>>> (SmartBuilderImpl.java:205)
> > >>>>     at io.takari.maven.builder.smart.SmartBuilderImpl$
> > ProjectBuildTask.run
> > >>>> (SmartBuilderImpl.java:77)
> > >>>>     at java.util.concurrent.Executors$RunnableAdapter.call
> > >>>> (Executors.java:511)
> > >>>>     at java.util.concurrent.FutureTask.run (FutureTask.java:266)
> > >>>>     at java.util.concurrent.ThreadPoolExecutor.runWorker
> > >>>> (ThreadPoolExecutor.java:1149)
> > >>>>     at java.util.concurrent.ThreadPoolExecutor$Worker.run
> > >>>> (ThreadPoolExecutor.java:624)
> > >>>>     at java.lang.Thread.run (Thread.java:748)
> > >>>>
> > >>>> On Sat, Feb 24, 2018 at 2:01 PM, Stephen Connolly <
> > >>>> stephen.alan.connolly@gmail.com> wrote:
> > >>>>
> > >>>>> On 24 February 2018 at 22:00, Stephen Connolly <
> > >>>>> stephen.alan.connolly@gmail.com> wrote:
> > >>>>>
> > >>>>> > Hi,
> > >>>>> >
> > >>>>> > We solved 22 issues:
> > >>>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > >>>>> > version=12341428&styleName=Text&projectId=12316922
> > >>>>> >
> > >>>>> > There are 381 issues left in JIRA for Maven core:
> > >>>>> > https://issues.apache.org/jira/issues/?jql=project%20%
> > >>>>> > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> > >>>>> > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> > >>>>> >
> > >>>>> > Staging repo:
> > >>>>> > https://repository.apache.org/content/repositories/maven-1401/
> > >>>>> >
> > >>>>> > The distributable binaries and sources can be found here:
> > >>>>> > https://repository.apache.org/content/repositories/maven-
> > >>>>> > 1401/org/apache/maven/apache-maven/3.5.3/
> > >>>>> >
> > >>>>> > Specifically the zip, tarball and source archives can
be found
> > here:
> > >>>>> > https://repository.apache.org/content/repositories/maven-
> > >>>>> > 1401/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.
> > 3-bin.zip
> > >>>>> > https://repository.apache.org/content/repositories/maven-
> > >>>>> > 1401/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.3-
> > >>>>> bin.tar.gz
> > >>>>> > https://repository.apache.org/content/repositories/maven-
> > >>>>> > 1401/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.
> > 3-src.zip
> > >>>>> > https://repository.apache.org/content/repositories/maven-
> > >>>>> > 1401/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.3-
> > >>>>> src.tar.gz
> > >>>>> >
> > >>>>> > The release artifacts are staged for distribution in:
> > >>>>> > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.5.3
> > >>>>> >
> > >>>>> > Source release checksum(s):
> > >>>>> > apache-maven-3.5.3-src.tar.gz sha1:
> 60905d8b8b025b091f456ec25ad60d
> > >>>>> da56c26ad5
> > >>>>> > sha256: 471748340cdc7f78b0b0c7bdf9e539
> > 9738e6721c08e166f59ef400f1dd10
> > >>>>> 7e19
> > >>>>> > apache-maven-3.5.3-src.zip: sha1: a9be51d571165261dfb2e0c8ecc6b4
> > >>>>> f1c4c96766
> > >>>>> > sha256: 109ac07fa337e582b8e6741f179e9f
> > 09166cae0fc9b3f44d4a35a2a2c7cc
> > >>>>> bd57
> > >>>>> >
> > >>>>> > Git tag:
> > >>>>> > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
> > >>>>> > 3383c37e1f9e9b3bc3df5050c29c8aff9f295297
> > >>>>> >
> > >>>>> > Staging site:
> > >>>>> > https://maven.apache.org/components/ref/3-LATEST/
> > >>>>> >
> > >>>>> > Vote open for 72 hours.
> > >>>>> >
> > >>>>> > [ ] +1
> > >>>>> > [ ] +0
> > >>>>> > [ ] -1
> > >>>>> >
> > >>>>> > Thanks,
> > >>>>> >
> > >>>>> > Stephen.
> > >>>>> >
> > >>>>>
> > >>>>>
> > >>>>> $ sra https://repository.apache.org/content/repositories/maven-
> 1401
> > >>>>> 3.5.3
> > >>>>> Analyzer...
> > >>>>>
> > >>>>> stagingUrl: https://repository.apache.org/
> > >>>>> content/repositories/maven-1401
> > >>>>> groupId: org.apache.maven
> > >>>>> artifactId: apache-maven
> > >>>>> version: 3.5.3
> > >>>>>
> > >>>>> Source ZIP url exists.
> > >>>>> https://repository.apache.org/content/repositories/maven-140
> > >>>>> 1/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.3-src.zip
> > >>>>>
> > >>>>> Source ZIP SHA1 url exists.
> > >>>>> https://repository.apache.org/content/repositories/maven-140
> > >>>>> 1/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.
> > 3-src.zip.sha1
> > >>>>>
> > >>>>> Binary ZIP url exists.
> > >>>>> https://repository.apache.org/content/repositories/maven-140
> > >>>>> 1/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.3-bin.zip
> > >>>>>
> > >>>>> Binary ZIP SHA1 url exists.
> > >>>>> https://repository.apache.org/content/repositories/maven-140
> > >>>>> 1/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.
> > 3-bin.zip.sha1
> > >>>>>
> > >>>>> Calculated SHA1 of source ZIP matches published SHA1 of source
ZIP.
> > >>>>> a9be51d571165261dfb2e0c8ecc6b4f1c4c96766
> > >>>>>
> > >>>>> Calculated SHA1 of binary ZIP matches published SHA1 of binary
ZIP.
> > >>>>> 4a4844990333e2548540729ce9ab57f52a63148d
> > >>>>>
> > >>>>> Git revision of release as determined from
> > >>>>> maven-core-3.5.3.jar:org/apache/maven/messages/build.propert
> > >>>>> ies(buildNumber):
> > >>>>> 3383c37e1f9e9b3bc3df5050c29c8aff9f295297
> > >>>>>
> > >>>>> Files that are present in the source distribution but not in
the
> > source
> > >>>>> revision:
> > >>>>> DEPENDENCIES
> > >>>>>
> > >>>>
> > >>>>
> > >>>
> > >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message