maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tibor Digana <tibordig...@apache.org>
Subject Re: [3/3] maven-surefire git commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"
Date Sun, 18 Feb 2018 03:39:02 GMT
I will explain again everything.
Do not worry, please.

The build won't fail if you use -Djdk.home=/path/to/jdk. We don't have to
force the users to change JDK if they are fine with 1.6.
The library commons-lang3:3.7 was especially needed during our testing but
not in the main code, therefore Java 1.6 is still fine for this plugin
because the "os.version" is not read from this library.
It is also written in README.md on how to build the project. It is also
safe for release plugin.
The Jenkins CI passed:
https://builds.apache.org/job/maven-wip/job/maven-surefire/job/SUREFIRE-1463/
The information in master is old one - not related to current HEAD on
master.
The reason is that the libraries can still use javac compiler with "-source
1.6" but the integration tests are important, not the compiler.
Did you see this job?
https://builds.apache.org/job/maven-wip/job/maven-surefire/job/SUREFIRE-1463/

Cheers
Tibor


On Sun, Feb 18, 2018 at 4:24 AM, Olivier Lamy <olamy@apache.org> wrote:

> and now master fail again with jdk10...
> Why are you reverting my changes?
> As said in an email I wanted to have something working with jdk10.
> So please first discuss on the email thread if you are not happy with my
> changes...
>
>
> On 18 February 2018 at 10:36, <tibordigana@apache.org> wrote:
>
> > Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on jdk10"
> >
> > This reverts commit 8bcf1f14a8697ef3359d7598fbd8062a687f2d5a.
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/maven-surefire/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/maven-surefire/
> > commit/5e732c6b
> > Tree: http://git-wip-us.apache.org/repos/asf/maven-surefire/tree/
> 5e732c6b
> > Diff: http://git-wip-us.apache.org/repos/asf/maven-surefire/diff/
> 5e732c6b
> >
> > Branch: refs/heads/master
> > Commit: 5e732c6b2a87026ac56032cc8b2b7e8e92e6aa7e
> > Parents: 3c41c55
> > Author: Tibor17 <tibordigana@apache.org>
> > Authored: Sun Feb 18 00:13:42 2018 +0100
> > Committer: Tibor17 <tibordigana@apache.org>
> > Committed: Sun Feb 18 00:13:42 2018 +0100
> >
> > ----------------------------------------------------------------------
> >  pom.xml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> > http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/
> > 5e732c6b/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/pom.xml b/pom.xml
> > index 2bcb0d7..3592b31 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -89,7 +89,7 @@
> >      <mavenVersion>2.2.1</mavenVersion>
> >      <!-- <shadedVersion>2.12.4</shadedVersion> commented out due
to
> > https://issues.apache.org/jira/browse/MRELEASE-799 -->
> >      <mavenPluginPluginVersion>3.5</mavenPluginPluginVersion>
> > -    <commonsLang3Version>3.7</commonsLang3Version>
> > +    <commonsLang3Version>3.5</commonsLang3Version>
> >      <commonsIoVersion>2.5</commonsIoVersion>
> >      <mavenSharedUtilsVersion>0.9</mavenSharedUtilsVersion>
> >      <powermockVersion>2.0.0-beta.5</powermockVersion>
> >
> >
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message