maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Scholte" <rfscho...@apache.org>
Subject Re: second fix for MNG-6330 [regression] Parents relativePath not verified anymore
Date Thu, 28 Dec 2017 18:10:46 GMT
Hi Karl Heinz,

just looking for a +1 from another committer before I merge it back to the  
master.

thanks,
Robert

On Thu, 28 Dec 2017 18:55:15 +0100, Karl Heinz Marbaise  
<khmarbaise@gmx.de> wrote:

> Hi Robert,
>
>
> On 28/12/17 17:58, Robert Scholte wrote:
>> Hi,
>>  Looking for someone to confirm and second MNG-6330[1]
>
> how can I help here?
>
> Karl Heinz Marbaise
>
>> While working on the maven-release-plugin I discovered regression  
>> introduced in Maven 3.5.0 by a change to the ReactorModelCache[2]
>> This only occurs when a parent was cached and another module points to  
>> this parent, even though the relativePath for this parent results in a  
>> non-existing pom file.
>> Change is a simple null-check[3]
>> Regression covered by integration test[4]
>> Jenkins is happy[5]
>>  thanks,
>> Robert
>>  [1] https://issues.apache.org/jira/browse/MNG-6330
>> [2] https://issues.apache.org/jira/browse/MNG-6030
>> [3]  
>> https://github.com/apache/maven/commit/4eb5747e8229d0201b707052ce7f8ae2fe24eec2 

>>  [4]  
>> https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=cfd0cc629c2dd496554c59c1680fb1d90b1311b3
 
>>  [5]  
>> https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6330_RelativePath/  
>>   ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message