maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tibor17 <...@git.apache.org>
Subject [GitHub] maven-surefire pull request #171: [SUREFIRE-1445] Explicitly define Surefire...
Date Tue, 28 Nov 2017 23:04:51 GMT
Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/171#discussion_r153650439
  
    --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
---
    @@ -71,13 +71,22 @@ public SurefireProperties( KeyValueSource source )
             }
         }
     
    +    @Override
    +    public synchronized void putAll(Map<?, ?> t) {
    --- End diff --
    
    We have different conventions. Please see the spaces around brackets and new lines.
    The checkstyle plugin would crash the build. Did you try to run "mvn install -P run-its"?
    It would take quite long time to complete the build, cca one hour.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message