Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Developers List" <dev@maven.apache.org>
MIME-Version: 1.0
In-Reply-To: <77af7f90-e596-6425-59f9-c6ac7511f0b1@apache.org>
References: <CA+nPnMxyG2NePXpVqawe9jR=itHET6UudnN9CjHhv=oo-KCrxw@mail.gmail.com>
 <CAFNCU--2vrd5BeTvkxKCyX2ZQePqix7X=wmVsWdM5d49XeNgOw@mail.gmail.com>
 <F7057E1B-4313-4D7B-8EF1-99341DD1E1D0@talios.com> <CA+nPnMwUqmBuratD1Cpk=L9tACw_+qotrsUpCqdqRZXmWXgiTA@mail.gmail.com>
 <B148C967-1695-45C2-A15F-1FFF903BCB50@talios.com> <74C127B0-F707-4BBA-A2C1-D57E60C9C0FC@talios.com>
 <FAADDE14-C378-4D3D-8AEE-9AC8CCF91783@talios.com> <CALYGm1y9TMxAAihni7kbo=2rhun2xt4F8x0MykNLkBttv7GiHw@mail.gmail.com>
 <CA+nPnMzmkQ+8ZivTyBAbnj-5xQ4CsxUia1dLmif3mH97j0AJzA@mail.gmail.com>
 <CA+=+LrLO=Fc=ZYNTo4h2GdyiMawtdqVXu0bbm2tWxAcDzyJTzg@mail.gmail.com>
 <CA+=+LrL65LmGCvOwp-7MXKBiT=f9YRas5orm=ZeA82Z6OXM72Q@mail.gmail.com>
 <CA+=+Lr+Hae0xZa=KFat=tu-eKZEWWvYpk-WChwf2SCrEQyvZMw@mail.gmail.com> <77af7f90-e596-6425-59f9-c6ac7511f0b1@apache.org>
From: Stephen Connolly <stephen.alan.connolly@gmail.com>
Date: Fri, 15 Sep 2017 02:54:54 -0700
Message-ID: <CA+nPnMzpUYciYyt4+=JoTCYY1fkxzVzBocXQqbWAFJgb=Go+pw@mail.gmail.com>
Subject: Re: [VOTE] Release Apache Maven 3.5.1
To: Maven Developers List <dev@maven.apache.org>
Cc: =?UTF-8?B?UGV0ciDFoGlyb2vDvQ==?= <siroky.petr@gmail.com>,
	Igor Fedorenko <igor@ifedorenko.com>
Content-Type: multipart/alternative; boundary="001a1146603a8df4910559376228"
archived-at: Fri, 15 Sep 2017 09:55:06 -0000

--001a1146603a8df4910559376228
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On 14 September 2017 at 23:55, Michael Osipov <michaelo@apache.org> wrote:

> Am 2017-09-15 um 00:50 schrieb Petr =C5=A0irok=C3=BD:
>
>> I was able to easily fix our plugin by e.g. replacing
>> "Thread.currentThread().getContextClassLoader()" with
>> "this.getClass().getClassLoader()" (in the Mojo class) to get the plugin
>> classloader.
>>
>> I don't know though if the "Thread.currentThread().getCon
>> textClassLoader()"
>> is just misuse on our side or if it's something that more plugins may re=
ly
>> on.
>>
>
> Similar cause in MASSEMBLY: https://issues.apache.org/jira/browse/MNG-620=
9
>
> I think using TCCL is wrong here.


I agree, I think the TCCL is supposed to be for extension lookup.

If you want the plugin's classloader then that should be
`this.getClass().getClassLoader()` from the Mojo class.

If you want the classloader with all the extensions, that should be TCCL.

What is unclear to me is why we set TCCL to anything other than the project
realm. A pom plugin declaration of <extensions>true</extensions> should not
affect the TCCL that the plugin execution sees, so I wonder if the root bug
is that the fix allows the TCCL to be other than project realm?

Igor?


>
>
> On Thu, Sep 14, 2017 at 2:42 PM Petr =C5=A0irok=C3=BD <siroky.petr@gmail.=
com> wrote:
>>
>> Argh, I forgot to link the plugin source:
>>> https://github.com/kiegroup/droolsjbpm-integration/tree/7.3.
>>> 0.Final/kie-maven-plugin
>>>
>>> On Thu, Sep 14, 2017 at 2:41 PM Petr =C5=A0irok=C3=BD <siroky.petr@gmai=
l.com>
>>> wrote:
>>>
>>> Hello,
>>>>
>>>> I am seeing a (probably) similar issue with our custom plugin.
>>>>
>>>> See the reproducer:
>>>> https://github.com/psiroky/reproducers/tree/mvn351-kie-maven-plugin
>>>> (works
>>>> fine with maven 3.5.0, but fails with NPE with the RC of maven 3.5.1).
>>>>
>>>> I am not yet sure if the plugin is just doing something it's not
>>>> supposed
>>>> to, or if this is a regression in maven itself. I'll will take a deepe=
r
>>>> look.
>>>>
>>>> Petr
>>>>
>>>>
>>>> On Thu, Sep 14, 2017 at 1:53 PM Stephen Connolly <
>>>> stephen.alan.connolly@gmail.com> wrote:
>>>>
>>>> On 14 September 2017 at 04:43, Mark Derricutt <mark@talios.com> wrote:
>>>>>
>>>>> +2 non-binding from Mark!
>>>>>>>
>>>>>>
>>>>>> I was discussing this with a coworker and he made the comment that i=
f
>>>>>>
>>>>> this
>>>>>
>>>>>> change could break Mojos, maybe it shouldn't be in a point release -
>>>>>>
>>>>> whats
>>>>>
>>>>>> the policy on changes that may potentially break existing plugins?
>>>>>>
>>>>>>
>>>>> Well we need to assess the issue. Right now I don't even have a
>>>>> description
>>>>> of what went wrong. Any chance you could provide a replication... or
>>>>> mail
>>>>> me directly if you cannot share it publically and I may be able to
>>>>> produce
>>>>> a minimal reproduction from it.
>>>>>
>>>>> If this breaks a mojo that was doing something wrong in the first
>>>>> place,
>>>>> well that will not stop 3.5.1... OTOH if this exposes a bug in the
>>>>> issue
>>>>> "fixed" then I'd likely revert and respin.
>>>>>
>>>>> We really need a reproducer first.
>>>>>
>>>>>
>>>>>
>>>>>> --
>>>>>> "Great artists are extremely selfish and arrogant things" =E2=80=94 =
Steven
>>>>>>
>>>>> Wilson,
>>>>>
>>>>>> Porcupine Tree
>>>>>>
>>>>>> On Thu, Sep 14, 2017 at 10:29 AM, Mark Derricutt <mark@talios.com>
>>>>>>
>>>>> wrote:
>>>>>
>>>>>>
>>>>>> On 14 Sep 2017, at 10:26, Mark Derricutt wrote:
>>>>>>>
>>>>>>> Calling -2 for vote if not too late.
>>>>>>>
>>>>>>> Actually - looking at the commit diff, I see in our code we did hav=
e
>>>>>>> <extensions>true</extensions> for the jasmine-maven-plugin which we
>>>>>>>
>>>>>> don't
>>>>>
>>>>>> actually need. Removing that from the mojo definition and running my
>>>>>>>
>>>>>> build
>>>>>>
>>>>>>> with the staged 3.5.1 release and everything builds fine.
>>>>>>>
>>>>>>> +2 non-binding from Mark!
>>>>>>>
>>>>>>> Mark
>>>>>>> ------------------------------
>>>>>>>
>>>>>>> "The ease with which a change can be implemented has no relevance a=
t
>>>>>>>
>>>>>> all
>>>>>
>>>>>> to whether it is the right change for the (Java) Platform for all
>>>>>>>
>>>>>> time."
>>>>>
>>>>>> =E2=80=94
>>>>>>
>>>>>>> Mark Reinhold.
>>>>>>>
>>>>>>> Mark Derricutt
>>>>>>> http://www.theoryinpractice.net
>>>>>>> http://www.chaliceofblood.net
>>>>>>> http://plus.google.com/+MarkDerricutt
>>>>>>> http://twitter.com/talios
>>>>>>> http://facebook.com/mderricutt
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

--001a1146603a8df4910559376228--