maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jon-bell <...@git.apache.org>
Subject [GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...
Date Sat, 29 Jul 2017 17:31:28 GMT
GitHub user jon-bell opened a pull request:

    https://github.com/apache/maven-surefire/pull/161

    SUREFIRE-1396: Provider class path is incorrect for custom provider in Failsafe

    Hi,
    When using a custom Surefire provider with Surefire (not Failsafe), the "provider classpath"
contains only the provider and surefire-api. However, when using a custom provider with Failsafe,
the provider class path ends up including a lot more... it seems like perhaps all plugins
that are loaded? This has caused some mayhem for me when using a custom provider in projects
that use a specific version of SLF4J... because then failsafe forces 1.5.6 to be loaded (from
this process of incorrectly finding the custom provider), causing a crash.
    
    This PR contains an integration test case showing the bug and a patch to solve it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jon-bell/maven-surefire SUREFIRE-1396

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
    
----
commit 04f66cdd828d131a028eb400d1ed26fe104fe3f2
Author: Jonathan Bell <jbell@cs.columbia.edu>
Date:   2017-07-25T03:43:36Z

    SUREFIRE-1396: Test case demonstrating broken handling of classpath for custom runners
in failsafe, plus a fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message