maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From etzelc <...@git.apache.org>
Subject [GitHub] maven-integration-testing issue #23: [MNG-6265] Integration test for Maven s...
Date Wed, 19 Jul 2017 11:07:01 GMT
Github user etzelc commented on the issue:

    https://github.com/apache/maven-integration-testing/pull/23
  
    Thanks for your testing effort. I am surprised both tests pass in your Windows environment
with 3.5.0. I tested the IT with two different clients (Windows 7 and Windows 10) and while
`folder-with- -space/pom.xml` passes, the `folder-with-)-closing-bracket/pom.xml` test fails.

    The `folder-with- -space/pom.xml` test was developed to cover MNG-6177 (https://issues.apache.org/jira/browse/MNG-6177),
which has no IT and was already targeting "special" characters like spaces and more.
    
    I have implemented the IT in a way to perform a successful maven run, since this is what
you usually expect from maven. The example `mvn -f "folderWithClosing)Bracket/pomFolder"`
from issue MNG-6256 (https://issues.apache.org/jira/browse/MNG-6256) was chosen to have a
very short example with no prerequisites. With 3.5.0 you should see the same error even if
a well formed POM exist at the specified location and you set additionally a goal (see IT
test `folder-with-)-closing-bracket/pom.xml`).
    I did not implement a dedicated test for the error message, because it may change over
the time and the purpose of my patch was not to have a correct error message (which is included
in the patch implicitly), but have a successful maven run.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message