maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tibor17 <...@git.apache.org>
Subject [GitHub] maven-surefire pull request #157: SUREFIRE-1383 dependenciesToScan Does Not ...
Date Sat, 01 Jul 2017 21:57:12 GMT
Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/157#discussion_r125169778
  
    --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
    @@ -847,12 +847,33 @@ private DefaultScanResult scanDependencies()
             {
                 try
                 {
    +                DefaultScanResult scanResult = new DefaultScanResult( Collections.EMPTY_LIST
);
    +                
    +                List<String> dependenciesToScanList = new ArrayList( Arrays.asList(
getDependenciesToScan() ) );
    --- End diff --
    
    No need to create two collections with 
    `List<String> dependenciesToScanList = new ArrayList( Arrays.asList( getDependenciesToScan()
) );`
    One modifiable collection can be with this code:
    `List<String> dependenciesToScanList = new ArrayList();`
    `Collections.addAll( dependenciesToScanList, getDependenciesToScan() );`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message