Return-Path: <dev-return-122827-archive-asf-public=cust-asf.ponee.io@maven.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id B0207200C6C
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  5 May 2017 19:36:00 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id AEBCA160BAF; Fri,  5 May 2017 17:36:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 014BD160BAA
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  5 May 2017 19:35:59 +0200 (CEST)
Received: (qmail 79133 invoked by uid 500); 5 May 2017 17:35:59 -0000
Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@maven.apache.org>
List-Help: <mailto:dev-help@maven.apache.org>
List-Post: <mailto:dev@maven.apache.org>
List-Id: "Maven Developers List" <dev.maven.apache.org>
Reply-To: "Maven Developers List" <dev@maven.apache.org>
Delivered-To: mailing list dev@maven.apache.org
Received: (qmail 79122 invoked by uid 99); 5 May 2017 17:35:58 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 May 2017 17:35:58 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id B17DDDFE15; Fri,  5 May 2017 17:35:58 +0000 (UTC)
From: michael-o <git@git.apache.org>
To: dev@maven.apache.org
Reply-To: dev@maven.apache.org
References: <git-pr-21-maven-integration-testing@git.apache.org>
In-Reply-To: <git-pr-21-maven-integration-testing@git.apache.org>
Subject: [GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...
Content-Type: text/plain
Message-Id: <20170505173558.B17DDDFE15@git1-us-west.apache.org>
Date: Fri,  5 May 2017 17:35:58 +0000 (UTC)
archived-at: Fri, 05 May 2017 17:36:00 -0000

Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven-integration-testing/pull/21#discussion_r115049986
  
    --- Diff: core-it-suite/src/test/resources/mng-6127/plugin/pom.xml ---
    @@ -0,0 +1,55 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <groupId>mng-6127</groupId>
    +  <artifactId>mng-6127-plugin</artifactId>
    +  <version>0.1</version>
    +  <packaging>maven-plugin</packaging>
    +
    +  <properties>
    +    <maven-version>3.3.1</maven-version>
    --- End diff --
    
    This should rather be `maven.version` as we always do in POMs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org