maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gfouquet <...@git.apache.org>
Subject [GitHub] maven-scm pull request #53: [SCM-707] Git : spaces in username / password in...
Date Sat, 15 Apr 2017 21:47:41 GMT
GitHub user gfouquet opened a pull request:

    https://github.com/apache/maven-scm/pull/53

    [SCM-707] Git : spaces in username / password in URL should be encode…

    …d as '%20' instead of '+'
    
    [SCM-707](https://issues.apache.org/jira/browse/SCM-707) implementation for git (in b41cf6d)
encodes spaces in URL using '+'. There is a unit test for special characters encoding but
it failed to detect this behaviour.
    
    I think [MRELEASE-908](https://issues.apache.org/jira/browse/MRELEASE-908) is a side effect
of this wrong encoding.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gfouquet/maven-scm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-scm/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit cd385d5d29f719dda025b9ffb376487a1b62e2f5
Author: Grégory Fouquet <gfouquet@armida.fr>
Date:   2017-04-15T20:21:03Z

    [SCM-707] Git : spaces in username / password in URL should be encoded as '%20' instead
of '+'

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message