maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tibor Digana <tibordig...@apache.org>
Subject Re: I think we are ready for 3.5.0-alpha-1
Date Fri, 17 Feb 2017 17:06:47 GMT
It happens with ArrayList filled up with objects in writer Thread.
Reader will see:
size=5, and Object array has all elements null.
In such cases I use ConcurrentLinkedQueue, thread-safe impl without using
locks - just write once and reads multiple times - or use Guava.
Does this happen with this?
final List<MavenProject> newItemsThatCanBeBuilt = analyzer.markAsFinished(
projectBuild.getProject() );
Map.get(null) will crash of course when key is element of
newItemsThatCanBeBuil.



On Fri, Feb 17, 2017 at 5:25 PM, Robert Scholte-6 [via Maven] <
ml-node+s40175n5898885h75@n5.nabble.com> wrote:

> Hi Karl Heinz,
>
> looking at the commit[1] I see that the projectBuildList.contains will
> prevent the NPE, but it looks weird to me that the projectBuildList does
> not contain a mavenProject which was marked as finished so can be built.
> Why is it null?
> If there's no clear reason yet, there should be at least an else-statement
>
> logging this.
> Looks to me more like a NPE prevention instead of fixing the root cause.
>
> -1 for me.
>
> thanks,
> Robert
>
> [1]
> https://git1-us-west.apache.org/repos/asf?p=maven.git;a=commitdiff;h=
> 238f789ad07a18c0dff7f884c9a5d3b47258fc47
>
>
> On Fri, 17 Feb 2017 16:56:23 +0100, Karl Heinz Marbaise
> <[hidden email] <http:///user/SendEmail.jtp?type=node&node=5898885&i=0>>
> wrote:
>
> > Hi,
> >
> > I have identified a bug[1] in Maven Core based on an issue related to
> > versions-maven-plugin:
> >
> > I have made already a fix for it and all tests are running[2].
> >
> > Any objection to merge that issue into master ?
> >
> > Kind regards
> > Karl Heinz Marbaise
> >
> > [1]: https://issues.apache.org/jira/browse/MNG-6170
> > [2]:
> > https://builds.apache.org/view/M-R/view/Maven/job/maven-
> 3.x-jenkinsfile/job/MNG-6170/
> >
> >
> > On 08/02/17 21:01, Stephen Connolly wrote:
> >> I think all the important stuff is merged. I'll take a final review
> >> through
> >> and then cut alpha-1
> >>
> >> We can still add stuff if necessary for an alpha-2 but I'd much prefer
>
> >> to
> >> focus that on shaking out bugs.
> >>
> >> Ideally we do at most 3 alpha's before soft-code-freeze and a beta (at
> >> which point it should only be serious bug fixes)
> >>
> >> Then we give the beta some soak and cut the release
> >>
> >> I toyed with spinning RCs but I'm thinking alpha and beta are better
> >> terms
> >>
> >> Thoughts?
> >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5898885&i=1>
> > For additional commands, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5898885&i=2>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5898885&i=3>
> For additional commands, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5898885&i=4>
>
>
>
> ------------------------------
> If you reply to this email, your message will be added to the discussion
> below:
> http://maven.40175.n5.nabble.com/I-think-we-are-ready-for-3-5-0-alpha-1-
> tp5897626p5898885.html
> To start a new topic under Maven Developers, email
> ml-node+s40175n142166h86@n5.nabble.com
> To unsubscribe from Maven Developers, click here
> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==>
> .
> NAML
> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>




--
View this message in context: http://maven.40175.n5.nabble.com/I-think-we-are-ready-for-3-5-0-alpha-1-tp5897626p5898899.html
Sent from the Maven Developers mailing list archive at Nabble.com.
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message