Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Developers List" <dev@maven.apache.org>
MIME-Version: 1.0
References: <f9a67140-ab01-e583-b575-a7de252626f1@schulte.it>
 <25f24166-bbea-2249-e53e-e9d4542a83db@schulte.it> <CA+nPnMym1N2adoJdkvoPfKwD4HjfRnL0vv58hJ_uz4456KYNbA@mail.gmail.com>
 <CA+nPnMwnU_y9vsGcCmGna1EE49aJDuOq=BLFh=T3j9i9+DP9XA@mail.gmail.com>
 <33c650c7-2bcb-ba8d-b007-b76046435241@schulte.it> <CA+nPnMyR50wn8DDM+TiupEYrz4c+yt=XHw45-St0x9fDxsOOWw@mail.gmail.com>
 <7a413bed-ad06-8aa7-de48-da7d2bafe588@schulte.it> <CAMYdmasbSi_i0F+greBjUaYGFpej7R_YuNAF_9OCp+OKMQdV8A@mail.gmail.com>
In-Reply-To: <CAMYdmasbSi_i0F+greBjUaYGFpej7R_YuNAF_9OCp+OKMQdV8A@mail.gmail.com>
From: Stephen Connolly <stephen.alan.connolly@gmail.com>
Date: Fri, 20 Jan 2017 00:02:53 +0000
Message-ID: <CA+nPnMyOEUdOVAUQVv1inwFXC+W4TncH-_XhA5sSs49t50Q7Ag@mail.gmail.com>
Subject: Re: [IT MNG-5958 - Take 2]: Please review integration test for MNG-5958
To: Maven Developers List <dev@maven.apache.org>
Content-Type: multipart/alternative; boundary=001a113dff2cab5b1f05467b5fa2
archived-at: Fri, 20 Jan 2017 00:03:09 -0000

--001a113dff2cab5b1f05467b5fa2
Content-Type: text/plain; charset=UTF-8

Ok in that case create a throwaway fork of your branch with changes that
uses the changed integration tests

If that passes we can throw away the throwaway branch and merge both.

(Need for throwaway branch will go away soon... I'm just trying to bash
bugs in updates to Jenkins plugins to enable the feature we require)

On Thu 19 Jan 2017 at 23:09, Anton Tanasenko <atg.sleepless@gmail.com>
wrote:

> New ITs should run successfully against 3.3.9 and 3.5.0-SNAPSHOT+changes.
>
> It doesn't make sense to test a feature which is not in.
>
>
>
> 2017-01-19 22:46 GMT+02:00 Christian Schulte <cs@schulte.it>:
>
>
>
> > Am 01/19/17 um 13:06 schrieb Stephen Connolly:
>
> > > Ideal would be to create a *new throw-away branch* that is forked from
>
> > > current master and just changes the itBranch in the Jenkinsfile to the
>
> > > integration test branch you want to merge.
>
> >
>
> > To verify the changes to the ITs are working without any changes to the
>
> > core? Verify the new ITs can be run successfully without any changes in
>
> > the core? This won't work because the updated ITs are testing the
>
> > updated behaviour which would not be there. The added ITs would fail
>
> > without the corresponding changes. Running the updated core against the
>
> > updated ITs is the only way to show the ITs can be run successfully.
>
> >
>
> >
>
> > ---------------------------------------------------------------------
>
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> >
>
> >
>
>
>
>
>
> --
>
> Regards,
>
> Anton.
>
> --
Sent from my phone

--001a113dff2cab5b1f05467b5fa2--