maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tibor Digana <tibordig...@apache.org>
Subject Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.
Date Fri, 06 Jan 2017 15:43:52 GMT
Christian thx for the logs.
Can you please send me *log.txt* from these folders?
surefire-integration-tests/target/Surefire34SecurityManagerIT_testSecurityManager
surefire-integration-tests/target/Surefire1295AttributeJvmCrashesToTestsIT_crashInFork
surefire-integration-tests/target/Surefire1295AttributeJvmCrashesToTestsIT_crashInReusableFork
surefire-integration-tests/target/Surefire1295AttributeJvmCrashesToTestsIT_crashInSingleUseFork

Cheers
Tibor

On Fri, Jan 6, 2017 at 3:11 AM, Tibor Digana <tibordigana@apache.org> wrote:

> Hello guys,
>
> Sorry for late reply.
> I do not want to remove your work from the commit - it's not fair to
> anyone and therefore I would like to open PR at GitHub and I would like to
> amend the commit with my proposal and *you guys feel free to comment on
> the PR - everybody is welcome*.
> I understand that this takes your and my spare time but that's the only
> way we can friendly continue.
> In my experiences the professionals must communicate in code review and
> however they have good technical understanding always they may have
> different decisions and consensus is the only way we will coexist.
>
> :) I will send you link in GitHub in a day.
>
> I see we will make good job together!
>
>
>
>
>
> On Mon, Jan 2, 2017 at 3:42 PM, Tibor Digana <tibordigana@apache.org>
> wrote:
>
>> I also have such feeling that Maven became a playground.
>> Last week I saw it in reality and after Robert told me we made playground
>> in our sources I could not believe this could happen in such professional
>> project like Maven.
>>
>> I would appreciate it if the change [1] e5a6b9c8d4f514100a01dea2acf1fb059e294968
>> was reverted in Surefire and a new pull request was open at GitHub making
>> the code review.
>> I use to do this with myself with big changes and I am waiting for anyone
>> in the PR. We are doing the same with one excellent guy from another ASF
>> project who is supporting us with JUnit 5 addons and this works pretty well.
>>
>> The situation in Surefire is quite ambitious to release Versions 2.19.2
>> and 3.0.0-RC1 in parallel with 2.19.3 JDK9 support and JUnit 5 support now
>> in January.
>>
>> The problem is that these Surefire three plugins are so easy to crash
>> with whatever changes and therefore I implemented dumping internal errors
>> to dump files which will help us investigate two Jira issues - critical and
>> blocker. And there are much more thinks to talk about the features...
>>
>> I would really appreciate if we could behave like ordinal users in our
>> project and provide a pull request in GitHub and call for code review.
>> This does not mean only Surefire.
>>
>> So now please revert last change [1] and let's start from the ground.
>> We should again learn from the beginning and start communicating in the
>> community; otherwise this is the end of the project.
>>
>> [1] https://git1-us-west.apache.org/repos/asf?p=maven-surefire.
>> git&a=commit&h=e5a6b9c8d4f514100a01dea2acf1fb059e294968
>>
>> We can talk about more visions, or I can open Wiki for such talks which I
>> think we will appreciate because everybody can add her/his visions.
>>
>> WDYT?
>>
>> Cheers
>> Tibor
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message