maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arnaud Héritier <aherit...@gmail.com>
Subject Re: maven-integration-testing git commit: [MNG-3599] Need to use --legacy-local-repository on newer maven versions
Date Wed, 11 Jan 2017 19:42:13 GMT
The stability of tests is more important than anything else from my POV
As far as we correctly track the issue .... we can temporarily add it

On Wed, Jan 11, 2017 at 8:33 PM, Stephen Connolly <
stephen.alan.connolly@gmail.com> wrote:

> Well it also only seems to be affecting the Windows builds, so my analysis
> may be partly incorrect
>
> But it does fix the test
>
> Unless I hear otherwise in the next couple of hours I'll merge and
> retrigger the current branches so we can get an all clear on them
>
> On Wed 11 Jan 2017 at 19:25, Robert Scholte <rfscholte@apache.org> wrote:
>
> > Yes, please make an issue for 3.5.1
> >
> >
> >
> > "The issue is that wagon comes from a different repository URL and we are
> >
> > storing the proxy URL that the artifact came from IIUC"
> >
> >
> >
> > This looks odd to me. This would mean that if the enterprise/company
> >
> > repository get's a new URL, your local repo would becomes useless, right?
> >
> > Well, I had such situation recently, didn't had local repo issues.
> >
> > Do we have logging from failing tests?
> >
> >
> >
> > Is this something which could be tested with the MRM?
> >
> >
> >
> > Robert
> >
> >
> >
> > On Wed, 11 Jan 2017 20:12:02 +0100, Stephen Connolly
> >
> > <stephen.alan.connolly@gmail.com> wrote:
> >
> >
> >
> > > Robert, Jason, Hervé and Arnaud
> >
> > >
> >
> > >
> >
> > > What do you think?
> >
> > >
> >
> > > Will we just commit this as is and create an issue to find a longer
> term
> >
> > > fix for the issue?
> >
> > >
> >
> > > (I could add a FIXME to the test as a marker that we intend to fix the
> >
> > > test
> >
> > > more correctly at a future point in time)
> >
> > >
> >
> > > On Wed 11 Jan 2017 at 17:02, Stephen Connolly <
> >
> > > stephen.alan.connolly@gmail.com> wrote:
> >
> > >
> >
> > >> I don't like this... but it fixes the test... unless anyone has a
> better
> >
> > >> proposal I will merge this to master
> >
> > >>
> >
> > >> On 11 January 2017 at 13:57, <stephenc@apache.org> wrote:
> >
> > >>
> >
> > >> Repository: maven-integration-testing
> >
> > >>
> >
> > >>
> >
> > >> Updated Branches:
> >
> > >>
> >
> > >>
> >
> > >>   refs/heads/mng-3599 03c07e10b -> a27d19f88
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >> [MNG-3599] Need to use --legacy-local-repository on newer maven
> versions
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >> Project:
> >
> > >> http://git-wip-us.apache.org/repos/asf/maven-integration-testing/repo
> >
> > >>
> >
> > >>
> >
> > >> Commit:
> >
> > >>
> > http://git-wip-us.apache.org/repos/asf/maven-integration-
> testing/commit/a27d19f8
> >
> > >>
> >
> > >>
> >
> > >> Tree:
> >
> > >>
> > http://git-wip-us.apache.org/repos/asf/maven-integration-
> testing/tree/a27d19f8
> >
> > >>
> >
> > >>
> >
> > >> Diff:
> >
> > >>
> > http://git-wip-us.apache.org/repos/asf/maven-integration-
> testing/diff/a27d19f8
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >> Branch: refs/heads/mng-3599
> >
> > >>
> >
> > >>
> >
> > >> Commit: a27d19f88684cd5cf66f39df7c2f87ab9606d70e
> >
> > >>
> >
> > >>
> >
> > >> Parents: 03c07e1
> >
> > >>
> >
> > >>
> >
> > >> Author: Stephen Connolly <stephen.alan.connolly@gmail.com>
> >
> > >>
> >
> > >>
> >
> > >> Authored: Wed Jan 11 13:57:02 2017 +0000
> >
> > >>
> >
> > >>
> >
> > >> Committer: Stephen Connolly <stephen.alan.connolly@gmail.com>
> >
> > >>
> >
> > >>
> >
> > >> Committed: Wed Jan 11 13:57:02 2017 +0000
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >> ------------------------------------------------------------
> ----------
> >
> > >>
> >
> > >>
> >
> > >>  .../maven/it/MavenITmng3599useHttpProxyForWebDAVMk2Test.java
>  | 2
> >
> > >> ++
> >
> > >>
> >
> > >>
> >
> > >>  1 file changed, 2 insertions(+)
> >
> > >>
> >
> > >>
> >
> > >> ------------------------------------------------------------
> ----------
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> > http://git-wip-us.apache.org/repos/asf/maven-integration-
> testing/blob/a27d19f8/core-it-suite/src/test/java/org/apache/maven/it/
> MavenITmng3599useHttpProxyForWebDAVMk2Test.java
> >
> > >>
> >
> > >>
> >
> > >> ------------------------------------------------------------
> ----------
> >
> > >>
> >
> > >>
> >
> > >> diff --git
> >
> > >>
> > a/core-it-suite/src/test/java/org/apache/maven/it/
> MavenITmng3599useHttpProxyForWebDAVMk2Test.java
> >
> > >>
> > b/core-it-suite/src/test/java/org/apache/maven/it/
> MavenITmng3599useHttpProxyForWebDAVMk2Test.java
> >
> > >>
> >
> > >>
> >
> > >> index 6e9954b..45f9647 100644
> >
> > >>
> >
> > >>
> >
> > >> ---
> >
> > >>
> > a/core-it-suite/src/test/java/org/apache/maven/it/
> MavenITmng3599useHttpProxyForWebDAVMk2Test.java
> >
> > >>
> >
> > >>
> >
> > >> +++
> >
> > >>
> > b/core-it-suite/src/test/java/org/apache/maven/it/
> MavenITmng3599useHttpProxyForWebDAVMk2Test.java
> >
> > >>
> >
> > >>
> >
> > >> @@ -152,6 +152,7 @@ public class
> >
> > >> MavenITmng3599useHttpProxyForWebDAVMk2Test
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>          verifier = newVerifier( testDir.getAbsolutePath() );
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >> +        verifier.addCliOption( "--legacy-local-repository" );
> >
> > >>
> >
> > >>
> >
> > >>          verifier.addCliOption( "--settings" );
> >
> > >>
> >
> > >>
> >
> > >>          verifier.addCliOption( "settings.xml" );
> >
> > >>
> >
> > >>
> >
> > >>          verifier.addCliOption( "-X" );
> >
> > >>
> >
> > >>
> >
> > >> @@ -194,6 +195,7 @@ public class
> >
> > >> MavenITmng3599useHttpProxyForWebDAVMk2Test
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>          verifier = newVerifier( testDir.getAbsolutePath() );
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >> +        verifier.addCliOption("--legacy-local-repository");
> >
> > >>
> >
> > >>
> >
> > >>          verifier.addCliOption( "--settings" );
> >
> > >>
> >
> > >>
> >
> > >>          verifier.addCliOption( "settings.xml" );
> >
> > >>
> >
> > >>
> >
> > >>          verifier.addCliOption( "-X" );
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >>
> >
> > >> --
> >
> > > Sent from my phone
> >
> > --
> Sent from my phone
>



-- 
-----
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message