maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stuart McCulloch <mccu...@gmail.com>
Subject Re: MNG-5805 and 3.4.0-SNAPSHOT
Date Sat, 12 Nov 2016 22:27:46 GMT
Also note the MNG-5805 style of lifecycle configuration should go inside:

      <configuration>
        <lifecycles>
          <lifecycle>
            <id>foo</id>
            <lifecyclePhases> <!-- use this for MNG-5805 advanced lifecycle mappings
-->

rather than:

      <configuration>
        <lifecycles>
          <lifecycle>
            <id>foo</id>
            <phases> <!-- use this for legacy (deprecated) lifecycle mappings -->

There was a bug in Maven 3.3.9 where it accepted MNG-5805 style configuration using <phases>
but this broke backwards compatibility with plugins like flexmojos:

https://issues.apache.org/jira/browse/MNG-5958

If you stick with <lifecyclePhases> then your MNG-5805 lifecycle configuration will
work with 3.3.9 and 3.4.0+

--  
Cheers, Stuart


On Saturday, 12 November 2016 at 22:07, Stuart McCulloch wrote:

> Hi Mirko,
>  
> Could you provide more details on how to recreate this?
>  
> While 3.4.0-SNAPSHOT uses a different version of sisu-plexus to 3.3.9 (0.3.3 vs 0.3.2)
the XML conversion code didn't change between those versions.
>  
> There have been changes to the Maven lifecycle components since 3.3.9 which could influence
parsing - but I’d need a sample build/testcase to narrow it down further.
>  
> --
> Cheers, Stuart
>  
> On Saturday, 12 November 2016 at 21:33, Mirko Friedenhagen wrote:
>  
> > Hello,
> >  
> > I am playing with MNG-5805 which works fine with Maven 3.3.9. However
> > with a late SNAPSHOT from 2016-10-31 I get the following:
> >  
> > 9180 [INFO] 1788 [WARNING] Expected TEXT, not XML: START_TAG seen
> > ...<process-resources><mojos>... @3:217
> >  
> > 9180 [INFO] java.lang.Throwable
> >  
> > 9181 [INFO] at org.eclipse.sisu.plexus.PlexusXmlBeanConverter.parseBean(PlexusXmlBeanConverter.java:267)
> >  
> >  
> > Regards Mirko
> > https://issues.apache.org/jira/browse/MNG-5805
> >  
> > Apache Maven 3.4.0-SNAPSHOT (a277f6f43a9b52c17b6aa2af069554edd2b0e42e;
> > 2016-10-31T21:53:43+01:00)
> > --
> > http://illegalstateexception.blogspot.com/
> > https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen)
> > https://bitbucket.org/mfriedenhagen/
> >  
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org (mailto:dev-unsubscribe@maven.apache.org)
> > For additional commands, e-mail: dev-help@maven.apache.org (mailto:dev-help@maven.apache.org)
> >  
> >  
> >  
>  
>  


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message