maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hboutemy <...@git.apache.org>
Subject [GitHub] maven issue #94: MNG-5889 - adding logic that looks for the file argument an...
Date Sun, 13 Nov 2016 18:23:11 GMT
Github user hboutemy commented on the issue:

    https://github.com/apache/maven/pull/94
  
    let's help: I dug into core-its, to find what existing IT to extend, since .mvn feature
should have an IT already
    => found mng-5771-core-extensions IT, which already tests 3 conditions: I think it's
the right place to add one more
    here are the pointers:
    - the IT source: https://github.com/apache/maven-integration-testing/blob/master/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5771CoreExtensionsTest.java
    - associated test projects: https://github.com/apache/maven-integration-testing/tree/master/core-it-suite/src/test/resources/mng-5771-core-extensions/client
    
    I suppose writing the IT will simply require to copy testCoreExtension() method and not
setting basedir on the Verifier, but add the new option
    
    here is core-its intro: http://maven.apache.org/core-its/core-it-suite/
    
    do you want to try? Or I do it (now that I had a look and found existing IT, seems easy)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message