Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Developers List" <dev@maven.apache.org>
From: =?ISO-8859-1?Q?Herv=E9?= BOUTEMY <herve.boutemy@free.fr>
To: Maven Developers List <dev@maven.apache.org>
Subject: Re: maven-resolver git commit: Fix Checkstyle errors on package-info.java
Date: Tue, 18 Oct 2016 00:15:25 +0200
Message-ID: <5535429.73I30x3ltI@herve-desktop>
User-Agent: KMail/4.13.3 (Linux/3.13.0-98-generic; KDE/4.13.3; x86_64; ; )
In-Reply-To: <4e3b17a6-5d93-bbef-66f4-6fc9ffe45689@apache.org>
References: <2fc5d504a0964a6d8ef070e779dcace0@git.apache.org> <4028361.Ec2BgGzciz@herve-desktop> <4e3b17a6-5d93-bbef-66f4-6fc9ffe45689@apache.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
archived-at: Mon, 17 Oct 2016 22:15:35 -0000

uh, why is it ignoring // CHECKSTYLE_OFF: RegexpHeader?

$ git branch
* (d=E9tach=E9 de 0dc0cca)
  1.0.x
  master

$ mvn deploy
...

[INFO] --- maven-jar-plugin:3.0.0:jar (default-jar) @ maven-resolver-ap=
i ---
[INFO] Building jar: /home/herve/projets/maven/git/maven-resolver/maven=
-
resolver-api/target/maven-resolver-api-1.2.0-SNAPSHOT.jar
[INFO]=20
[INFO] --- maven-site-plugin:3.5.1:attach-descriptor (attach-descriptor=
) @=20
maven-resolver-api ---
[INFO]=20
[INFO] --- maven-checkstyle-plugin:2.15:check (checkstyle-check) @ mave=
n-
resolver-api ---
[INFO] There are 66 errors reported by Checkstyle 6.1.1 with=20
config/maven_checks.xml ruleset.
[INFO] Ignored 66 errors, 0 violation remaining.


And why is it more happy when you change file content, without having t=
his=20
regexp matched in the end neither?

Regards,

Herv=E9

Le lundi 17 octobre 2016 23:46:51 Michael Osipov a =E9crit :
> Am 2016-10-17 um 22:16 schrieb Herv=E9 BOUTEMY:
> > Le lundi 17 octobre 2016 21:41:07 Michael Osipov a =E9crit :
> >> Am 2016-10-17 um 21:27 schrieb Herv=E9 BOUTEMY:
> >>> just for the records: does not fix any errors reported by Checkst=
yle
> >>>=20
> >>> "// CHECKSTYLE_OFF: RegexpHeader" remains in the files to ignore =
the
> >>> standard header check (that cannot be applied to package-info.jav=
a)
> >>=20
> >> Do you still have errors?
> >=20
> > I did not have errors before, and don't have after: that's the role=
 of the
> > CHECKSTYLE_OFF: RegexpHeader
> >=20
> >> I was not able to deploy since checkstyle
> >> complained about them. Aligned the style to the rest of our source=
 made
> >> it magically work.
> >=20
> > strange, since even with your change, the style is not compliant: t=
he
> > first
> > line should start with "package"
> >=20
> > can you share the error you get?
>=20
> $ git branch
> * (HEAD detached at 0dc0cca)
>=20
> $ mvn deploy
> ...
> [INFO]
> [INFO] --- maven-jar-plugin:3.0.0:jar (default-jar) @ maven-resolver-=
api ---
> [INFO] Building jar:
> D:\Entwicklung\Projekte\maven-resolver\maven-resolver-api\target\mave=
n-resol
> ver-api-1.2.0-SNAPSHOT.jar [INFO]
> [INFO] --- maven-site-plugin:3.5.1:attach-descriptor (attach-descript=
or)
> @ maven-resolver-api ---
> [INFO]
> [INFO] --- maven-checkstyle-plugin:2.15:check (checkstyle-check) @
> maven-resolver-api ---
> [INFO] There are 77 errors reported by Checkstyle 6.1.1 with
> config/maven_checks.xml ruleset.
> [ERROR] src\main\java\org\eclipse\aether\artifact\package-info.java[1=
]
> (header) RegexpHeader: Zeile entspricht nicht der erwarteten
> Header-Zeile '^package '.
> [ERROR] src\main\java\org\eclipse\aether\collection\package-info.java=
[1]
> (header) RegexpHeader: Zeile entspricht nicht der erwarteten
> Header-Zeile '^package '.
> [ERROR] src\main\java\org\eclipse\aether\deployment\package-info.java=
[1]
> (header) RegexpHeader: Zeile entspricht nicht der erwarteten
> Header-Zeile '^package '.
> [ERROR] src\main\java\org\eclipse\aether\graph\package-info.java[1]
> (header) RegexpHeader: Zeile entspricht nicht der erwarteten
> Header-Zeile '^package '.
> [ERROR]
> src\main\java\org\eclipse\aether\installation\package-info.java[1]
> (header) RegexpHeader: Zeile entspricht nicht der erwarteten
> Header-Zeile '^package '.
> [ERROR] src\main\java\org\eclipse\aether\metadata\package-info.java[1=
]
> (header) RegexpHeader: Zeile entspricht nicht der erwarteten
> Header-Zeile '^package '.
> [ERROR] src\main\java\org\eclipse\aether\package-info.java[1] (header=
)
> RegexpHeader: Zeile entspricht nicht der erwarteten Header-Zeile
> '^package '.
> [ERROR] src\main\java\org\eclipse\aether\repository\package-info.java=
[1]
> (header) RegexpHeader: Zeile entspricht nicht der erwarteten
> Header-Zeile '^package '.
> [ERROR] src\main\java\org\eclipse\aether\resolution\package-info.java=
[1]
> (header) RegexpHeader: Zeile entspricht nicht der erwarteten
> Header-Zeile '^package '.
> [ERROR] src\main\java\org\eclipse\aether\transfer\package-info.java[1=
]
> (header) RegexpHeader: Zeile entspricht nicht der erwarteten
> Header-Zeile '^package '.
> [ERROR] src\main\java\org\eclipse\aether\version\package-info.java[1]=

> (header) RegexpHeader: Zeile entspricht nicht der erwarteten
> Header-Zeile '^package '.
> [INFO] Ignored 66 errors, 11 violations remaining.
> [INFO]
> ---------------------------------------------------------------------=
---
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Maven Artifact Resolver ............................ SUCCESS [=

> 32.965 s]
> [INFO] Maven Artifact Resolver API ........................ FAILURE [=

> 3.829 s]
> [INFO] Maven Artifact Resolver SPI ........................ SKIPPED
> [INFO] Maven Artifact Resolver Test Utilities ............. SKIPPED
> [INFO] Maven Artifact Resolver Utilities .................. SKIPPED
> [INFO] Maven Artifact Resolver Implementation ............. SKIPPED
> [INFO] Maven Artifact Resolver Connector Basic ............ SKIPPED
> [INFO] Maven Artifact Resolver Transport Classpath ........ SKIPPED
> [INFO] Maven Artifact Resolver Transport File ............. SKIPPED
> [INFO] Maven Artifact Resolver Transport HTTP ............. SKIPPED
> [INFO] Maven Artifact Resolver Transport Wagon ............ SKIPPED
> [INFO]
> ---------------------------------------------------------------------=
---
> [INFO] BUILD FAILURE
> [INFO]
> ---------------------------------------------------------------------=
---
> [INFO] Total time: 36.998 s
> [INFO] Finished at: 2016-10-17T23:44:10+02:00
> [INFO] Final Memory: 36M/494M
> [INFO]
> ---------------------------------------------------------------------=
---
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:2.15:check
> (checkstyle-check) on project maven-resolver-api: You have 11 Checkst=
yle
> violations. -> [Help 1]
> [ERROR]
>=20
>=20
>=20
>=20
>=20
> ---------------------------------------------------------------------=

> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org