maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé BOUTEMY <herve.bout...@free.fr>
Subject Re: Maven 3.4.0 color output and default slf4j implementation
Date Wed, 19 Oct 2016 12:37:25 GMT
Le mercredi 19 octobre 2016 13:35:52 Stephen Connolly a écrit :
> On 19 October 2016 at 12:37, Hervé BOUTEMY <herve.boutemy@free.fr> wrote:
> > Le lundi 17 octobre 2016 20:58:16 Stephen Connolly a écrit :
> > > Could you at least raise the issues that you see as blocking Gossip
> > 
> > against
> > 
> > > it. I presume you have them currently in your context and it would be
> > 
> > good
> > 
> > > to capture them now so that if somebody can add those features to Gossip
> > > (assuming they are aligned with the direction Gossip wants to go) then
> > > we
> > > can reconsider?
> > 
> > ok, let's do it once again: logging configuration with CLI and relative
> > timestamp (initial mail from this thread)
> > see "relative timestamp" in http://mail-archives.apache.
> > org/mod_mbox/maven-dev/201607.mbox/%3CCAK8jvqxYNK4weM2Frp4Brg3J7Ey
> > byjBiCsSRdGuNMQhYAG728Q%40mail.gmail.com%3E
> 
> Did you raise that issue against Gossip (I see the issue management says
> where to create issues:
> https://github.com/jdillon/gossip/blob/0aa3da715a0d92369a0398b71131186c350fc
> 793/pom.xml#L57-L60)... I do not see any issues there:
> https://github.com/jdillon/gossip/issues
please read the thread content: already asked, already replied


> > > I see this change as more of a feature gap that would have blocked the
> > > release, not a rejection of the proposal to switch to Gossip
> > 
> > in fact, it's a rejection of any change that does not have at least all
> > features of slf4j-simple (without having a precise list of features)
> > 
> > I think I'll go with this monkey-patched slf4j simple provider: that's the
> > safest and is maintainable. NOthing prevents us to switch later if useful.
> > 
> > Regards,
> > 
> > Hervé
> > 
> > > On Monday 17 October 2016, Hervé BOUTEMY <herve.boutemy@free.fr> wrote:
> > > > adding some rendering code like supported by Gossip, and eventually
> > 
> > adding
> > 
> > > > the
> > > > rendering feature to slf4j-simple seemed sufficiently easy to give it
> > > > a
> > > > try:
> > > > done and was as easy as expected
> > > > 
> > > > Now, adding every slf4j-simple feature to Gossip require more work
> > 
> > (it's
> > 
> > > > not
> > > > simply about rendering: need to really dig into code), and is not
> > > > guaranteed
> > > > to give smooth experience for everybody: the two missing features that
> > > > were
> > > > reported clearly are perhaps the first two of a long list. Jason told
> > 
> > that
> > 
> > > > these updates should be feasible, but seemed nobody really tried.
> > > > 
> > > > 
> > > > This option of keeping usual slf4j-simple with a little patch seems
> > > > currently
> > > > not foolish
> > > > 
> > > > Regards,
> > > > 
> > > > Hervé
> > > > 
> > > > Le lundi 17 octobre 2016 06:49:21 Jason van Zyl a écrit :
> > > > > So your approach was to fork some code, instead of trying to fix
> > 
> > Gossip?
> > 
> > > > I
> > > > 
> > > > > haven’t been paying much attention just trying to understand why
you
> > > > 
> > > > would
> > > > 
> > > > > fork instead of working with Jason Dillon to get that added? Did
he
> > 
> > not
> > 
> > > > > respond or you couldn’t make a PR?
> > > > > 
> > > > > Jason
> > > > > 
> > > > > > On Oct 17, 2016, at 1:11 AM, Hervé BOUTEMY <herve.boutemy@free.fr
> > > > 
> > > > <javascript:;>> wrote:
> > > > > > Hi Mirko,
> > > > > > 
> > > > > > short answer: yes
> > > > > > 
> > > > > > more precise answer:
> > > > > > Gossip slf4j provider does not have color feature but has
> > 
> > extensible
> > 
> > > > > > Renderer interface which permits to inject Maven colorized
> > > > > > renderer
> > > > > > [1]
> > > > > > with one configuration line [2]
> > > > > > 
> > > > > > In maven-slf4j-simple, I copied the same Maven colorized renderer
> > 
> > code
> > 
> > > > [3]
> > > > 
> > > > > > and injected it in slf4j simple through a Groovy script to patch
> > 
> > slf4j
> > 
> > > > > > simple source code [4]: not as straightforward than one
> > 
> > fonciguration
> > 
> > > > > > line, but same effect with clean separation of Maven-specific
> > > > > > extension
> > > > > > code to support colorized output with Maven styles
> > > > > > 
> > > > > > Regards,
> > > > > > 
> > > > > > Hervé
> > > > > > 
> > > > > > [1]
> > > > > > https://github.com/apache/maven/blob/master/maven-> >
> > > > 
> > > > embedder/src/main/java/
> > > > 
> > > > > > org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> > > > > > 
> > > > > > [2]
> > > > > > https://github.com/apache/maven/blob/master/maven-> >
> > > > 
> > > > embedder/src/main/resou
> > > > 
> > > > > > rces/META-INF/com.planet57.gossip/config.properties#L29
> > > > > > 
> > > > > > [3]
> > > > > > https://github.com/apache/maven/blob/MNG-6093/maven-> >
> > > > 
> > > > slf4j-provider/src/ma
> > > > 
> > > > > > in/java/org/slf4j/impl/MavenSimpleLogger.java
> > > > > > 
> > > > > > [4]
> > > > > > https://github.com/apache/maven/blob/MNG-6093/maven-> >
> > > > 
> > > > slf4j-provider/src/ma
> > > > 
> > > > > > in/script/patch-slf4j-simple.groovy>
> > > > > > 
> > > > > > Le lundi 17 octobre 2016 07:00:50 Mirko Friedenhagen a écrit
:
> > > > > >> Hello Hervé,
> > > > > >> 
> > > > > >> I would like a simple approach here. If I understand it
> > > > > >> correctly,
> > > > 
> > > > gossip
> > > > 
> > > > > >> was chosen because of its color capability. If we could
have this
> > > > 
> > > > without
> > > > 
> > > > > >> switching the log provider it would be a good thing IMO.
Gossip
> > 
> > seems
> > 
> > > > to
> > > > 
> > > > > >> be
> > > > > >> unconfigurable by means of system properties, which is a
pity.
> > > > > >> 
> > > > > >> Regards
> > > > > >> Mirko
> > > > > >> 
> > > > > >>> Jason Dillon started the Maven output color work by
providing us
> > 
> > a
> > 
> > > > > >>> Gossip
> > > > > >>> slf4j provider renderer adapted to Maven context: thanks
Jason
> > > > > >>> 
> > > > > >>> Then current master uses Gossip slf4j provider by default
with
> > 
> > this
> > 
> > > > > >>> customization.
> > > > > >>> 
> > > > > >>> Given there were feedback from people finding the change
> > 
> > disturbing
> > 
> > > > vs
> > > > 
> > > > > >>> usual
> > > > > >>> slf4j simple provider (some are just about changing
habits, some
> > 
> > are
> > 
> > > > > >>> about
> > > > > >>> missing features like logging configuration with CLI
and
> > > > > >>> relative
> > > > > >>> timestamp),
> > > > > >>> I tried another approach: patch slf4j simple provider
to add
> > > > > >>> Maven-specific
> > > > > >>> rendering features.
> > > > > >>> 
> > > > > >>> The result is available on MNG-6093 branch with
> > 
> > maven-slf4j-provider
> > 
> > > > > >>> module
> > > > > >>> addition [1]
> > > > > >>> 
> > > > > >>> I didn't really try to add features or extensions to
slf4j
> > 
> > Gossip.
> > 
> > > > > >>> What is the best option for Maven: try to improve slf4j
Gossip
> > > > > >>> or
> > > > > >>> use
> > > > > >>> this
> > > > > >>> slf4j simple patched version?
> > > > > >>> 
> > > > > >>> Regards,
> > > > > >>> 
> > > > > >>> Hervé
> > > > > >>> 
> > > > > >>> [1] https://github.com/apache/maven/tree/MNG-6093/maven->
>
> > > > 
> > > > slf4j-provider
> > > > 
> > > > > >>> ------------------------------------------------------------
> > > > 
> > > > ---------
> > > > 
> > > > > >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > 
> > > > <javascript:;>
> > > > 
> > > > > >>> For additional commands, e-mail: dev-help@maven.apache.org
> > > > 
> > > > <javascript:;>
> > > > 
> > > > > > ------------------------------------------------------------
> > 
> > ---------
> > 
> > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > 
> > > > <javascript:;>
> > > > 
> > > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > 
> > > > <javascript:;>
> > > > 
> > > > > Thanks,
> > > > > 
> > > > > Jason
> > > > > 
> > > > > ----------------------------------------------------------
> > > > > Jason van Zyl
> > > > > Founder, Takari and Apache Maven
> > > > > http://twitter.com/jvanzyl
> > > > > http://twitter.com/takari_io
> > > > > ---------------------------------------------------------
> > > > > 
> > > > > 
> > > > > 
> > > > > ------------------------------------------------------------
> > 
> > ---------
> > 
> > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > 
> > <javascript:;>
> > 
> > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > 
> > > > <javascript:;>
> > > > 
> > > > 
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > 
> > <javascript:;>
> > 
> > > > For additional commands, e-mail: dev-help@maven.apache.org
> > 
> > <javascript:;>
> > 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message