maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tibor17 <...@git.apache.org>
Subject [GitHub] maven-surefire pull request #120: Add convinient method to check for the cur...
Date Sun, 11 Sep 2016 20:37:56 GMT
Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/120#discussion_r78302041
  
    --- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java
---
    @@ -159,4 +164,10 @@ public static IntegrationTestSuiteResults parseReportList( List<ReportTestSuite>
                 throw new RuntimeException( "Couldn't parse XML reports", e );
             }
         }
    +
    +    public static void assumeJavaVersion(JavaVersion version)
    +    {
    +        assumeThat( "java.specification.version: ",
    +                SystemUtils.JAVA_SPECIFICATION_VERSION, is( greaterThanOrEqualTo( version.toString()
) ) );
    --- End diff --
    
    Unfortunately `org.apache.commons.lang3.JavaVersion` is not `Comparable`. How would this
work with string `1.10`? JDK 9, I guess, returns `9` instead of `1.9`. Did you try? If so
then such lexical comparison should be fine. JDK 10 I hope will follow the same pattern. 
Version `10.1` bigger than `10`. Are you facing any problem with lexicographic comparison?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message