maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hboutemy <...@git.apache.org>
Subject [GitHub] maven-surefire pull request #117: [SUREFIRE-1254] add color messages
Date Wed, 07 Sep 2016 00:06:23 GMT
Github user hboutemy commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/117#discussion_r77741146
  
    --- Diff: maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
---
    @@ -34,10 +34,11 @@
     import org.apache.maven.plugins.annotations.Mojo;
     import org.apache.maven.plugins.annotations.Parameter;
     import org.apache.maven.plugins.annotations.ResolutionScope;
    -import org.apache.maven.shared.utils.ReaderFactory;
     import org.apache.maven.shared.utils.StringUtils;
     import org.apache.maven.surefire.suite.RunResult;
     
    +import static org.apache.maven.shared.utils.ReaderFactory.FILE_ENCODING;
    +
    --- End diff --
    
    is it really intentional to reformat everything to have static import on any static access?
I don't find it convenient in general.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message