Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Developers List" <dev@maven.apache.org>
From: "Richard Sand" <rsand@idfconnect.com>
To: dev@maven.apache.org
Subject: opinions on MJAVADOC-451
Date: Mon, 01 Aug 2016 22:33:30 +0000
Message-Id: <em418d1f3f-be81-4437-a153-6b43e15d472a@desktop-cfd7uhs>
Reply-To: "Richard Sand" <rsand@idfconnect.com>
User-Agent: eM_Client/7.0.26567.0
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="------=_MBB6D3CA18-A4A2-429B-83D3-18C85F0BEF87"
archived-at: Mon, 01 Aug 2016 22:33:33 -0000

--------=_MBB6D3CA18-A4A2-429B-83D3-18C85F0BEF87
Content-Type: text/plain; format=flowed; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi all,

I'd like to ask for opinions on=20
https://issues.apache.org/jira/browse/MJAVADOC-451. Robert Scholte and I=
=20
have been discussing this off list and essentially disagree on it.

The request is very simple - to add a "skip" parameter to the=20
javadoc:fix goal. In my projects we are using the fix goal unattended,=20
i.e. with the parameter "force=3Dtrue", as part of the regular build=20
lifecycle.

Most goals (including javadoc) that run in the regular lifecycle have a=20
skip option. Robert's position (and forgive me if I misrepresent this at=
=20
all Robert and please weigh in) is that javadoc:fix should not be used=20
in the lifecycle and that the goal should in fact have=20
requireDirectInvocation=3Dtrue. He also pointed out to me that I can=20
create a profile to enable/disable the goal as an alternative.

My opinion is that, since the goal does not require direct invocation,=20
then running within the lifecycle has to be considered acceptable use of=
=20
the goal. And having a skip parameter adds 5 lines of code, is a common=20
and normal pattern used by many other plugins/goals, and allows the goal=
=20
to be used in this fashion without introducing even more profiles.

I've submitted patches for this issue and also several other issues in=20
the javadoc plugin as I continue to work through getting the goal to=20
work well automated. Just pointing out that I'm not just asking for the=20
larger community to do stuff to make my life easier - I'm trying to=20
contribute as best I can and provide patches for what I uncover.

Best regards,

Richard


--------=_MBB6D3CA18-A4A2-429B-83D3-18C85F0BEF87--