maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From khmarbaise <...@git.apache.org>
Subject [GitHub] maven pull request #88: [MNG-5910] Fixed the description of the POM referenc...
Date Tue, 19 Jul 2016 18:56:04 GMT
Github user khmarbaise commented on a diff in the pull request:

    https://github.com/apache/maven/pull/88#discussion_r71401238
  
    --- Diff: maven-model-builder/src/test/java/org/apache/maven/model/building/ComplexActivationTest.java
---
    @@ -56,5 +56,26 @@ public void testAndConditionInActivation()
             assertEquals( "activated-1", result.getEffectiveModel().getProperties().get(
"profile.file" ) );
             assertNull( result.getEffectiveModel().getProperties().get( "profile.miss" )
);
         }
    +    
    +    public void testConditionExistingAndMissingInActivation() throws Exception
    +    {
    +        Properties sysProperties = new Properties();
    +        sysProperties.setProperty( "myproperty", "test" );
    +
    +        ModelBuilder builder = new DefaultModelBuilderFactory().newInstance();
    +        assertNotNull( builder );
    +
    +        DefaultModelBuildingRequest request = new DefaultModelBuildingRequest();
    +        request.setProcessPlugins( true );
    +        request.setPomFile( getPom( "complexEmptyAndMissing" ) );
    +        request.setSystemProperties( sysProperties );
    +
    +        try {
    --- End diff --
    
    As far as I know we use JUnit 4.X where you can @Rule for exceptions ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message