maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olivier Lamy <ol...@apache.org>
Subject Re: maven git commit: [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)
Date Tue, 14 Jun 2016 22:03:58 GMT
On 15 June 2016 at 05:25, <hboutemy@apache.org> wrote:

> Repository: maven
> Updated Branches:
>   refs/heads/master ecdb0bc2b -> e7a783db1
>
>
> [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)
>
> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/e7a783db
> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/e7a783db
> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/e7a783db
>
> Branch: refs/heads/master
> Commit: e7a783db1f577a340a91f6c958f1b9319c52c176
> Parents: ecdb0bc
> Author: Hervé Boutemy <hboutemy@apache.org>
> Authored: Tue Jun 14 21:25:02 2016 +0200
> Committer: Hervé Boutemy <hboutemy@apache.org>
> Committed: Tue Jun 14 21:25:02 2016 +0200
>
> ----------------------------------------------------------------------
>  .../org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java    | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/maven/blob/e7a783db/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> ----------------------------------------------------------------------
> diff --git
> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> index 00007cc..52e0489 100644
> ---
> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> +++
> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> @@ -50,7 +50,7 @@ extends com.planet57.gossip.render.PatternRenderer
>                  break;
>
>              case INFO:
> -                buff.append( ansi().bold().fgGreen().a( level.name()
> ).reset() );
> +                buff.append( ansi().bold().fgBlue().a( level.name()
> ).reset() );
>


What about having color configurable? Ask few people they will all have
different opinions about the color to use.
So to avoid all of complains and jira issue asking color change etc...
having some configuration could IMHO ease our life :-)  (french part you
know "les goûts et les couleurs" :-) )

Well not sure how as the current configuration file is included in the jar.
Furthermore I have no idea our externalise that.





>                  break;
>
>              case WARN:
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message