maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé BOUTEMY <herve.bout...@free.fr>
Subject Re: maven git commit: [MNG-6038] use Gossip slf4j provider (with level color support)
Date Sun, 12 Jun 2016 21:55:16 GMT
Le dimanche 12 juin 2016 22:51:36 Michael Osipov a écrit :
> Am 2016-06-11 um 13:27 schrieb Hervé BOUTEMY:
> > if someone has an objection, just tell and we can easily revert
> 
> I am afraid that I have to downvote this for two reasons:
the issues you're facing do not seem to be tied to Gossip slf4j provider bug 
MNG-3705 general ANSI color support: issues found, now we have to work to fix 
them (eventually helping JAnsi, since I thought JAnsi was mature...)

> 
> 1. JAnsi requires Microsoft Visual C++ 2008 SP1 Redistributable Package
> [1]. According to Microsoft, this applies to Windows 2000 Service Pack
> 4, Windows 7, Windows Server 2003, Windows Server 2008, Windows Server
> 2008 R2, Windows Vista, Windows XP [2].
> 
> No one on our side has properly documented this.
at this step, where do you expect to document it?
And it's not clear to me that this lib is required for anything else than 
Windows XP (as I read JAnsi website).
I don't know if we have a Windows specialist to check

> 
> 2. Maven completely quits if JAnsi does not support a platform:
JAnsi contains a try/catch on AnsiConcole.systemInstall(): perhaps it's not 
sufficient
I don't have BSD platform myself: can you please help find the right try/catch 
to have a fallback in case of missing native lib? This should only happen for 
isatty() call, ie not really something absolutely a showstopper

Regards,

Hervé

> =========================
> [mosipov@bsd10 ~]$ uname -a
> FreeBSD bsd10 10.3-RELEASE-p2 FreeBSD 10.3-RELEASE-p2 #0: Wed May  4
> 06:03:51 UTC 2016
> root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64
> [mosipov@bsd10 ~]$ apache-maven-3.4.0-SNAPSHOT/bin/mvn -v
> ---------------------------------------------------
> constituent[0]: file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/conf/logging/
> constituent[1]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/cdi-api-1.0.jar
> constituent[2]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-embedder-3.4.0-SNAP
> SHOT.jar constituent[3]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-settings-3.4.0-SNAP
> SHOT.jar constituent[4]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/plexus-utils-3.0.24.jar
> constituent[5]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-core-3.4.0-SNAPSHOT
> .jar constituent[6]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-model-3.4.0-SNAPSHO
> T.jar constituent[7]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/commons-lang3-3.4.jar
> constituent[8]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-settings-builder-3.
> 4.0-SNAPSHOT.jar constituent[9]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-builder-support-3.4
> .0-SNAPSHOT.jar constituent[10]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/plexus-interpolation-1.22
> .jar constituent[11]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/plexus-component-annotati
> ons-1.6.jar constituent[12]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/plexus-sec-dispatcher-1.4
> .jar constituent[13]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/plexus-cipher-1.7.jar
> constituent[14]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-repository-metadata
> -3.4.0-SNAPSHOT.jar constituent[15]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-artifact-3.4.0-SNAP
> SHOT.jar constituent[16]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-plugin-api-3.4.0-SN
> APSHOT.jar constituent[17]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/org.eclipse.sisu.plexus-0
> .3.3.jar constituent[18]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/jsr250-api-1.0.jar
> constituent[19]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/javax.inject-1.jar
> constituent[20]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/org.eclipse.sisu.inject-0
> .3.3.jar constituent[21]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-model-builder-3.4.0
> -SNAPSHOT.jar constituent[22]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/guava-19.0.jar
> constituent[23]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/jansi-1.12.jar
> constituent[24]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-aether-provider-3.4
> .0-SNAPSHOT.jar constituent[25]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/aether-api-1.0.2.v2015011
> 4.jar constituent[26]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/aether-spi-1.0.2.v2015011
> 4.jar constituent[27]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/aether-util-1.0.2.v201501
> 14.jar constituent[28]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/aether-impl-1.0.2.v201501
> 14.jar constituent[29]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/guice-4.0-no_aop.jar
> constituent[30]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/aopalliance-1.0.jar
> constituent[31]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/maven-compat-3.4.0-SNAPSH
> OT.jar constituent[32]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/wagon-provider-api-2.10.j
> ar constituent[33]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/slf4j-api-1.7.16.jar
> constituent[34]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/commons-cli-1.3.1.jar
> constituent[35]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/wagon-http-2.10-shaded.ja
> r constituent[36]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/wagon-http-shared-2.10.ja
> r constituent[37]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/jsoup-1.7.2.jar
> constituent[38]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/commons-lang-2.6.jar
> constituent[39]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/commons-io-2.2.jar
> constituent[40]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/wagon-file-2.10.jar
> constituent[41]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/aether-connector-basic-1.
> 0.2.v20150114.jar constituent[42]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/aether-transport-wagon-1.
> 0.2.v20150114.jar constituent[43]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/gossip-slf4j-2.0.0.jar
> constituent[44]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/gossip-core-2.0.0.jar
> constituent[45]:
> file:/home/mosipov/apache-maven-3.4.0-SNAPSHOT/lib/gossip-bootstrap-2.0.0.ja
> r ---------------------------------------------------
> Exception in thread "main" java.lang.UnsatisfiedLinkError: Could not
> load library. Reasons: [no jansi64-1.12 in java.library.path, no
> jansi-1.12 in java.library.path, no jansi in java.library.path]
>          at org.fusesource.hawtjni.runtime.Library.doLoad(Library.java:182)
>          at org.fusesource.hawtjni.runtime.Library.load(Library.java:140)
>          at
> org.fusesource.jansi.internal.CLibrary.<clinit>(CLibrary.java:42)
>          at
> org.fusesource.jansi.AnsiConsole.wrapOutputStream(AnsiConsole.java:48)
>          at org.fusesource.jansi.AnsiConsole.<clinit>(AnsiConsole.java:38)
>          at org.apache.maven.cli.MavenCli.main(MavenCli.java:215)
>          at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>          at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62
> ) at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
> .java:43) at java.lang.reflect.Method.invoke(Method.java:498)
>          at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.ja
> va:289) at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>          at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.
> java:415) at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> =========================
> 
> There is not even a fallback mode.
> 
> [1] https://github.com/fusesource/jansi#windows-xp-users
> [2]
> https://www.microsoft.com/en-us/download/details.aspx?displaylang=en&id=5582
> > Le samedi 11 juin 2016 11:26:10 hboutemy@apache.org a écrit :
> >> Repository: maven
> >> 
> >> Updated Branches:
> >>   refs/heads/master 427f18c3a -> 644ac9c40
> >> 
> >> [MNG-6038] use Gossip slf4j provider (with level color support)
> >> 
> >> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> >> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/644ac9c4
> >> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/644ac9c4
> >> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/644ac9c4
> >> 
> >> Branch: refs/heads/master
> >> Commit: 644ac9c40ad41bf61e3b099918af33b8eb950621
> >> Parents: 427f18c
> >> Author: Hervé Boutemy <hboutemy@apache.org>
> >> Authored: Sat Jun 11 13:26:05 2016 +0200
> >> Committer: Hervé Boutemy <hboutemy@apache.org>
> >> Committed: Sat Jun 11 13:26:05 2016 +0200
> >> 
> >> ----------------------------------------------------------------------
> >> 
> >>  apache-maven/pom.xml | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >> 
> >> ----------------------------------------------------------------------
> >> 
> >> 
> >> http://git-wip-us.apache.org/repos/asf/maven/blob/644ac9c4/apache-maven/p
> >> om. xml
> >> ----------------------------------------------------------------------
> >> diff --git a/apache-maven/pom.xml b/apache-maven/pom.xml
> >> index 9405df8..37751cc 100644
> >> --- a/apache-maven/pom.xml
> >> +++ b/apache-maven/pom.xml
> >> @@ -92,8 +92,8 @@ under the License.
> >> 
> >>        <artifactId>aether-transport-wagon</artifactId>
> >>      
> >>      </dependency>
> >>      <dependency>
> >> 
> >> -      <groupId>org.slf4j</groupId>
> >> -      <artifactId>slf4j-simple</artifactId>
> >> +      <groupId>com.planet57.gossip</groupId>
> >> +      <artifactId>gossip-slf4j</artifactId>
> >> 
> >>      </dependency>
> >>    
> >>    </dependencies>
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message