maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eddiewebb <...@git.apache.org>
Subject [GitHub] maven-scm pull request: #resolves SCM-817 by encoding password bef...
Date Fri, 05 Feb 2016 18:51:23 GMT
GitHub user eddiewebb opened a pull request:

    https://github.com/apache/maven-scm/pull/44

    #resolves SCM-817 by encoding password before replace

    This resolves https://issues.apache.org/jira/browse/SCM-817 by encoding the password before
trying to match against the pre-encoded URL.
    
    Before this commit any passwords with special characters would print the encoded value.
    ```
    [INFO] Change the default 'git' provider implementation to 'jgit'.
    [INFO] fetch url: eddie:secr%24t@https//git.somesite.com/repo.git
    [INFO] push url: eddie:secr%24t@https//git.somesite.com/repo.git
    ```
    
    After this commit all passwords will be masked.
    ```
    [INFO] Change the default 'git' provider implementation to 'jgit'.
    [INFO] fetch url: eddie:******@https//git.somesite.com/repo.git
    [INFO] push url: eddie:******@https//git.somesite.com/repo.git
    ```
    
    I could not find any tests related specifically to security or masking, if there are tests
I can expand please provide direction!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Libertymutual/maven-scm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-scm/pull/44.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #44
    
----
commit 3aaad27f41cc2d51759cd895f7c269cb60cf3b35
Author: EDWARD WEBB <edward.webb@libertymutual.com>
Date:   2016-02-05T17:46:32Z

    #resolves SCM-817 by encoding password before replace

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message