maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Scholte" <rfscho...@apache.org>
Subject Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"
Date Sun, 10 Jan 2016 17:41:19 GMT
Op Sun, 10 Jan 2016 17:14:03 +0100 schreef Hervé BOUTEMY  
<herve.boutemy@free.fr>:

> perhaps there are artifacts in central, that are not built with Maven and
> don't have corresponding Maven artifact handlers
>
> but I suppose this check is only when maven-deploy-plugin will deploy to  
> a
> repo, isn't it?

Indeed, and I expect the same mechanism for the maven-install-plugin. If  
so, that needs to be changed too.

>
> When a project is built with Maven, this requirement of having one main
> artifact (and not only attachements) seems reasonable to me
>
> Regards,
>
> Hervé
>
> Le samedi 9 janvier 2016 19:34:37 Robert Scholte a écrit :
>> that's all handled by the ArtifactHandler, which knows how to translate
>> the packaging and type to a specific file extension.
>> So let me rephrase: in my opinion a non-pom MavenProject MUST have a  
>> main
>> artifact.
>>
>> Regarding the integration tests, to me they abuse the lifecycle for a
>> specific the packaging, for instance to get compiled classes, which are
>> than used as attachment.
>> None of the IT's contain a valid real world example.
>>
>> thanks,
>> Robert
>>
>> Op Sat, 09 Jan 2016 19:11:28 +0100 schreef Dan Tran <dantran@gmail.com>:
>> > what about packaging=bundle?  it has jar extension
>> >
>> > -D
>> >
>> > On Sat, Jan 9, 2016 at 9:04 AM, Robert Scholte <rfscholte@apache.org>
>> >
>> > wrote:
>> >> Hi,
>> >>
>> >> I've created MDEPLOY-205: MavenProject with only attachments must  
>> have
>> >> packaging "pom"[1]
>> >>
>> >> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78
>> >> fail.
>> >>
>> >> [ERROR] The following builds failed:
>> >> [ERROR] *  mdeploy-45-test\pom.xml
>> >> [ERROR] *  no-main-artifact-1\pom.xml
>> >> [ERROR] *  no-main-artifact-2\pom.xml
>> >> [ERROR] *  no-main-artifact-snapshot\pom.xml
>> >>
>> >> Original titles:
>> >> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
>> >> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
>> >>
>> >> Both sound valid as long *as the packaging is pom*
>> >> For the hygiene of the repository if the packaging says jar there  
>> should
>> >> always an artifactId-version.jar
>> >>
>> >> Anyone wants to convince me that I'm wrong?
>> >>
>> >> thanks,
>> >> Robert
>> >>
>> >> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
>> >> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
>> >> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> For additional commands, e-mail: dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message