maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nhojpatrick <...@git.apache.org>
Subject [GitHub] maven pull request: Patch for MNG-5956
Date Fri, 01 Jan 2016 01:49:56 GMT
GitHub user nhojpatrick opened a pull request:

    https://github.com/apache/maven/pull/75

    Patch for MNG-5956

    
    
    Issue raised https://issues.apache.org/jira/browse/MNG-5956
    
    If you use modules, and that results in the same project/pom being included multiple times
then an exception is thrown. But as it's the exact same project/pom it can simple be ignore
in my view.
    
    Simple project structure;
    ./pom.xml
    ./common/pom.xml
    ./sub1/pom.xml
    ./sub2/pom.xml
    
    If sub1 has nested modules but for some reason common should 50% of the time be rebuilded
if sub1 i rebuilt then adding ../common aids developers.
    
    if sub2 has a similar setup to sub2, then when you build at the root directory an error
is produces as both sub1 and sub2 reference common.
    
    This pull request should ignore where the project is an exact match of the same physical
pom.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nhojpatrick/maven bugfix/MNG-5956-invalid-DuplicateProjectException

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #75
    
----
commit 9e22e8abaae25d7f2aace7a505ca1fbc625f5c6a
Author: John Patrick <nhoj.patrick@gmail.com>
Date:   2016-01-01T01:42:22Z

    Patch for MNG-5956

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message