maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tibor Digana <tibor.dig...@googlemail.com>
Subject Re: [DISCUSS] MDEPLOY-205: MavenProject with only attachments must have packaging "pom"
Date Sun, 10 Jan 2016 11:08:48 GMT
Even if they are not real world ITs they are reasonable tests.
Did you debug the plugin?
In cases like this I am always debugging the code.

On Sat, Jan 9, 2016 at 7:34 PM, Robert Scholte <rfscholte@apache.org> wrote:

> that's all handled by the ArtifactHandler, which knows how to translate
> the packaging and type to a specific file extension.
> So let me rephrase: in my opinion a non-pom MavenProject MUST have a main
> artifact.
>
> Regarding the integration tests, to me they abuse the lifecycle for a
> specific the packaging, for instance to get compiled classes, which are
> than used as attachment.
> None of the IT's contain a valid real world example.
>
> thanks,
> Robert
>
>
> Op Sat, 09 Jan 2016 19:11:28 +0100 schreef Dan Tran <dantran@gmail.com>:
>
>
> what about packaging=bundle?  it has jar extension
>>
>> -D
>>
>> On Sat, Jan 9, 2016 at 9:04 AM, Robert Scholte <rfscholte@apache.org>
>> wrote:
>>
>> Hi,
>>>
>>> I've created MDEPLOY-205: MavenProject with only attachments must have
>>> packaging "pom"[1]
>>>
>>> If I apply such a change, tests written for MDEPLOY-45 and MDEPLOY-78
>>> fail.
>>>
>>> [ERROR] The following builds failed:
>>> [ERROR] *  mdeploy-45-test\pom.xml
>>> [ERROR] *  no-main-artifact-1\pom.xml
>>> [ERROR] *  no-main-artifact-2\pom.xml
>>> [ERROR] *  no-main-artifact-snapshot\pom.xml
>>>
>>> Original titles:
>>> MDEPLOY-45: Classifier not supported by deploy:deploy [2]
>>> MDEPLOY-78: Deploy with classifier does not deploy pom [3]
>>>
>>> Both sound valid as long *as the packaging is pom*
>>> For the hygiene of the repository if the packaging says jar there should
>>> always an artifactId-version.jar
>>>
>>> Anyone wants to convince me that I'm wrong?
>>>
>>> thanks,
>>> Robert
>>>
>>> [1] https://issues.apache.org/jira/browse/MDEPLOY-205
>>> [2] https://issues.apache.org/jira/browse/MDEPLOY-45
>>> [3] https://issues.apache.org/jira/browse/MDEPLOY-78
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


-- 
Cheers
Tibor

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message