maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kristian Rosenvold <kristian.rosenv...@gmail.com>
Subject Re: migrating Surefire to 3.0-RC1
Date Fri, 08 Jan 2016 08:41:20 GMT
I would recommend that you instead update the existing wiki page that we
use to gather "tips" about migrating plugins:


https://cwiki.apache.org/confluence/display/MAVEN/Plugin+migration+to+Maven3+dependencies

Kristian


2016-01-08 1:18 GMT+01:00 Tibor Digana <tibor.digana@googlemail.com>:

> Hi Andreas,
>
> See Robert's change. This maybe helps
>
> https://github.com/apache/maven-surefire/commit/9cb143414134a2c8f0bfec5b84f01571875a26fe
>
> On Thu, Jan 7, 2016 at 9:54 PM, Andreas Gudian <andreas.gudian@gmail.com>
> wrote:
>
> > Hey,
> >
> > funny, I ran into the very same problem when working on MCOMIPLER-203 and
> > after updating to Maven 3.0 dependencies: I'm getting the very same
> > exception when running the CompilerMojoTestCase.
> >
> > I'm all ears on how to solve that, so if anyone has a hint... :)
> >
> > I pushed a branch on github, and, for Tibor: here's how I did the
> > dependency resolution without using maven-compat or deprecated APIs
> > (although I have no clue if that's how it is supposed to be done):
> >
> >
> https://github.com/agudian/maven-plugins/commit/51648fc612c55920f7c887a42470a85914858e5e#diff-384c9234a411cc2c48bfb9c8731993b7
> >
> > For reference, that's what I'm trying to do:
> > https://issues.apache.org/jira/browse/MCOMPILER-203
> >
> > Thanks for any pointers,
> > Andreas
> >
> >
> > 2016-01-07 20:33 GMT+01:00 Tibor Digana <tibor.digana@googlemail.com>:
> >
> > > Now I removed maven-compat completely.
> > >
> > > <dependency>
> > >   <groupId>org.apache.maven.shared</groupId>
> > >   <artifactId>maven-artifact-transfer</artifactId>
> > >   <version>3.0-SNAPSHOT</version>
> > > </dependency>
> > >
> > > It seems release version is not available.
> > >
> > > I should resolve compilation error after new 3.0 AtrifactResolver and
> > > I will come back to you.
> > >
> > >
> > >
> > >
> > > return artifactResolver.resolveTransitively( Collections.singleton(
> > > providerArtifact ), originatingArtifact,
> > >                                              localRepository,
> > > remoteRepositories, artifactMetadataSource,
> > >                                              filter );
> > >
> > >
> > >
> > >
> > > On Thu, Jan 7, 2016 at 7:39 PM, Robert Scholte <rfscholte@apache.org>
> > > wrote:
> > >
> > > > Hi Tibor,
> > > >
> > > > Bullet 4: Remove maven-compat (or give it the test-scope if it is
> > > required
> > > > by the maven-plugin-testing-harness)
> > > >
> > > > Now I think you're at a state where Maven2 classes must be replaced
> > with
> > > > Maven3 solutions.
> > > >
> > > > Robert
> > > >
> > > > Op Thu, 07 Jan 2016 18:54:06 +0100 schreef Tibor Digana <
> > > > tibor.digana@googlemail.com>:
> > > >
> > > >
> > > > Hi Robert,
> > > >>
> > > >> I did as you said and I have new issue. Any dea?
> > > >>
> > > >>
> > > >>
> > > >>
> > >
> >
> testSurefireReportSingleError(org.apache.maven.plugins.surefire.report.SurefireReportMojoTest)
> > > >> Time elapsed: 0.042 sec  <<< ERROR!
> > > >>
> > > >>
> > >
> >
> org.codehaus.plexus.component.repository.exception.ComponentLookupException:
> > > >> java.util.NoSuchElementException
> > > >>       role: org.apache.maven.repository.RepositorySystem
> > > >>   roleHint:
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:253)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:241)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:235)
> > > >>     at
> > > org.codehaus.plexus.PlexusTestCase.lookup(PlexusTestCase.java:207)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.apache.maven.plugin.testing.AbstractMojoTestCase.setUp(AbstractMojoTestCase.java:118)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.apache.maven.plugins.surefire.report.SurefireReportMojoTest.setUp(SurefireReportMojoTest.java:56)
> > > >>     at junit.framework.TestCase.runBare(TestCase.java:139)
> > > >>     at junit.framework.TestResult$1.protect(TestResult.java:122)
> > > >>     at junit.framework.TestResult.runProtected(TestResult.java:142)
> > > >>     at junit.framework.TestResult.run(TestResult.java:125)
> > > >>     at junit.framework.TestCase.run(TestCase.java:129)
> > > >>     at junit.framework.TestSuite.runTest(TestSuite.java:252)
> > > >>     at junit.framework.TestSuite.run(TestSuite.java:247)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
> > > >>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > > >>     at java.lang.reflect.Method.invoke(Method.java:497)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
> > > >>     at
> > > >>
> > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
> > > >> Caused by: java.util.NoSuchElementException
> > > >>     at
> java.util.Collections$EmptyIterator.next(Collections.java:4189)
> > > >>     at
> > > >>
> > > >>
> > >
> >
> org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:249)
> > > >>     ... 25 more
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >> On Thu, Jan 7, 2016 at 6:10 PM, Robert Scholte <
> rfscholte@apache.org>
> > > >> wrote:
> > > >>
> > > >> Hi Tibor,
> > > >>>
> > > >>> so this is not how it should be done.
> > > >>> Compat contains classes which Maven2 classes which have been
> replaced
> > > by
> > > >>> Maven3 or are not used anymore.
> > > >>> Only plugins which need to stay compatible with Maven2 should
> include
> > > >>> this
> > > >>> dependency.
> > > >>>
> > > >>> I'll update the page, because we've decided to change the version
> to
> > > >>> 3.0-SNAPSHOT
> > > >>>
> > > >>> And regarding your other message: see the third bullet when using
> > > >>> maven-plugin-testing-harness. Use version 2.1 if you want to ensure
> > > that
> > > >>> the tests are Maven 3.0 compatible.
> > > >>>
> > > >>> If you need help, just let me know. By now I can recognize most
of
> > the
> > > >>> migration issues :)
> > > >>>
> > > >>> thanks,
> > > >>> Robert
> > > >>>
> > > >>> Op Thu, 07 Jan 2016 00:50:10 +0100 schreef Tibor Digana <
> > > >>> tibordigana@apache.org>:
> > > >>>
> > > >>> P=NP
> > > >>>
> > > >>>> maven-compat made the trick
> > > >>>>
> > > >>>> <dependency>
> > > >>>>   <groupId>org.apache.maven</groupId>
> > > >>>>   <artifactId>maven-compat</artifactId>
> > > >>>> </dependency>
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>> On Thu, Jan 7, 2016 at 12:09 AM, Tibor Digana-2 [via Maven]
<
> > > >>>> ml-node+s40175n5858124h84@n5.nabble.com> wrote:
> > > >>>>
> > > >>>> I missing this import in MOJO after migrating plugin to 3.0
> > > >>>>
> > > >>>>>
> > > >>>>>
> > > >>>>> import org.apache.maven.shared.artifact.resolve.ArtifactResolver;
> > > >>>>>
> > > >>>>> The doc [1] says that maven-artifact-transfer should be
used but
> it
> > > >>>>> does
> > > >>>>> not have yet a release version, or?
> > > >>>>>
> > > >>>>> <dependency>
> > > >>>>>   <groupId>org.apache.maven.shared</groupId>
> > > >>>>>   <artifactId>maven-artifact-transfer</artifactId>
> > > >>>>>   <version>0.0.1-SNAPSHOT</version>
> > > >>>>> </dependency>
> > > >>>>>
> > > >>>>> [1]
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > >
> >
> https://cwiki.apache.org/confluence/display/MAVEN/Plugin+migration+to+Maven3+dependencies
> > > >>>>>
> > > >>>>> --
> > > >>>>> Cheers
> > > >>>>> Tibor
> > > >>>>>
> > > >>>>>
> > > >>>>> ------------------------------
> > > >>>>> If you reply to this email, your message will be added
to the
> > > >>>>> discussion
> > > >>>>> below:
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > >
> >
> http://maven.40175.n5.nabble.com/migrating-Surefire-to-3-0-RC1-tp5858124.html
> > > >>>>> To start a new topic under Maven Developers, email
> > > >>>>> ml-node+s40175n142166h86@n5.nabble.com
> > > >>>>> To unsubscribe from Maven Developers, click here
> > > >>>>> <
> > > >>>>>
> > > >>>>>
> > >
> >
> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==
> > > >>>>> >
> > > >>>>> .
> > > >>>>> NAML
> > > >>>>> <
> > > >>>>>
> > > >>>>>
> > >
> >
> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
> > > >>>>> >
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>
> > > >>>>
> > > >>>> --
> > > >>>> View this message in context:
> > > >>>>
> > > >>>>
> > >
> >
> http://maven.40175.n5.nabble.com/migrating-Surefire-to-3-0-RC1-tp5858124p5858130.html
> > > >>>> Sent from the Maven Developers mailing list archive at Nabble.com.
> > > >>>>
> > > >>>>
> > > >>>
> ---------------------------------------------------------------------
> > > >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > >>> For additional commands, e-mail: dev-help@maven.apache.org
> > > >>>
> > > >>>
> > > >>>
> > > >>
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > >
> > > >
> > >
> > >
> > > --
> > > Cheers
> > > Tibor
> > >
> >
>
>
>
> --
> Cheers
> Tibor
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message