Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Developers List" <dev@maven.apache.org>
Subject: Re: svn commit: r1719483 - in /maven/doxia/doxia/trunk:
 doxia-core/src/main/java/org/apache/maven/doxia/markup/
 doxia-core/src/main/java/org/apache/maven/doxia/parser/
 doxia-core/src/main/java/org/apache/maven/doxia/sink/
 doxia-core/src/test/java/org/apach...
To: Maven Developers List <dev@maven.apache.org>
References: <20151211180120.8CF753A01D9@svn01-us-west.apache.org>
 <op.x9hulmt4kdkhrr@robertscholte.dynamic.ziggo.nl>
 <566B3997.9000003@schulte.it> <2693618.GQqBs1V6AS@herve-desktop>
From: Christian Schulte <cs@schulte.it>
Message-ID: <566BFA0E.5060404@schulte.it>
Date: Sat, 12 Dec 2015 11:42:22 +0100
User-Agent: Mozilla/5.0 (X11; OpenBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <2693618.GQqBs1V6AS@herve-desktop>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit

Am 12/12/15 um 11:20 schrieb Herv� BOUTEMY:
> is an API change in Doxia Sink API really necessary to add this HTML-specific
> feature (in very specific context)?

Not really that HTML-specific any more. I just renamed the method from 
'ssi' to 'directive' locally.

> Because whatever how the method is named, it won't have general meaning for
> most parsers and sink implementations

Depends on how it is used. It's just a comment starting with a '#' 
character which is handled differently than comments not starting with 
that character.

> notice that this API change was detected and the CI is now failing...

Noticed it. Nobody can ever enhance the Sink API?

> And instead of accepting this Sink API change, I would prefer to avoid it for
> this feature

If a new method cannot be added to the Sink API, the only option would 
be to handle the directives in every implementation of the following method.

     /**
      * Add a comment.
      *
      * @param comment The comment to write.
      * @since 1.1
      */
     void comment( String comment );

So every Sink implementation would need to start parsing comments then. 
I'd like to avoid that.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org