maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tibor17 <...@git.apache.org>
Subject [GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...
Date Sun, 20 Sep 2015 17:20:50 GMT
Github user Tibor17 commented on the pull request:

    https://github.com/apache/maven-surefire/pull/105#issuecomment-141812040
  
    Agreed, we can improve later on.
    Then the TestNG project should be informed that we continue using old
    configuration method.
    
    I have to ask you guys to publish documentation in
    maven-surefire-plugin project src/main/site/**/*.apt.vm with both
    examples for "-suitethreadpoolsize" and "-dataproviderthreadcount".
    
    I will commit the fix as soon as you introduce integration tests for
    all configurations.
    Please make sure that we hit more than 10 concurrent threads.
    Make sure that sanity check throws TestSetFailedException with
    meaningful message that "-suitethreadpoolsize" or
    "-dataproviderthreadcount" should be positive integer.
    
    On 9/19/15, Julien Herr <notifications@github.com> wrote:
    > Are we agree that the current PR is more about parameters than threading?
    >
    > Before the fix: "-suitethreadpoolsize" and "-dataproviderthreadcount" were
    > sent without conversion to TestNG, but TestNG need `Integer`.
    > After the fix: "-suitethreadpoolsize" and "-dataproviderthreadcount" are
    > sent with conversion to TestNG, what it supposed to be done.
    >
    > @dundacek already made [a fix](https://github.com/cbeust/testng/pull/798)
    > into TestNG for "-suitethreadpoolsize" but not for
    > "-dataproviderthreadcount". And I think we are all agree that TestNG is not
    > the good place for that.
    >
    > What I propose is to merge my fix because it has no risk
    > ("-suitethreadpoolsize" and "-dataproviderthreadcount" are `Integer` since
    > the begginning) and it will help users, then we can try to improve parallel
    > and/or use the "new" TestNG method.
    >
    > ---
    > Reply to this email directly or view it on GitHub:
    > https://github.com/apache/maven-surefire/pull/105#issuecomment-141709744
    
    
    -- 
    Cheers
    Tibor



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message