maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Graham (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
Date Sat, 15 Aug 2015 02:16:46 GMT

    [ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698029#comment-14698029
] 

Chris Graham edited comment on MPIR-234 at 8/15/15 2:16 AM:
------------------------------------------------------------

>> It should not be displayed, or inferred from any other (ie sub module) location.
>If you are looking at a module's site and you have to go changing it, you want to know
how to check out <b>that module</b>.

Perhaps I was not clear, or you missed my point.

Which is: In some SCM's checking out a sub module, it is impossible. It's an all or nothing
operation, not a cherry picking one.

>So there should be a "Source Repository" for sub-modules.

No there should not. Or, at best, it is only meaningful for those SCM's that can support it.

All you are doing in your example is cloning the <b>entire repo</b> [you cann't
not] and then checking out (-b) the branch. How is this a sub module?



was (Author: chrisgwarp):
>> It should not be displayed, or inferred from any other (ie sub module) location.
>If you are looking at a module's site and you have to go changing it, you want to know
how to check out <b>that module</b>.

Perhaps I was not clear, or you missed by point.

Which is: In some SCM's checking out a sub module, it is impossible. It's an all or nothing
operation, not a cherry picking one.

>So there should be a "Source Repository" for sub-modules.

No there should not. Or, at best, it is only meaningful for those SCM's that can support it.

All you are doing in your example is cloning the <b>entire repo</b> [you cann't
not] and then checking out (-b) the branch. How is this a sub module?


> SCM-link in site of multimodule projects should not append module name by default (at
least for git)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MPIR-234
>                 URL: https://issues.apache.org/jira/browse/MPIR-234
>             Project: Maven Project Info Reports Plugin
>          Issue Type: Bug
>          Components: scm
>    Affects Versions: 2.4
>            Reporter: Mirko Friedenhagen
>
> I have setup a simple multi module project (see https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by default add the
name of the module to the SCM-URLs in source-repository.html. So instead of https://github.com/mfriedenhagen/multi-module-sample/
I see https://github.com/mfriedenhagen/multi-module-sample/core/, git@github.com:mfriedenhagen/multi-module-sample.git/core
and git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for the core
module. All these URLs are invalid. For SVN this could be assumed to be the right behaviour,
for git and probably other SCMs this is not true. As a workaround I have to reconfigure the
scm section (see https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
> {code:xml}
> <scm>
>   <connection>${project.parent.scm.connection}</connection>
>   <developerConnection>${project.parent.scm.developerConnection}</developerConnection>
>   <url>${project.parent.scm.url}</url>
> </scm>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message