maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé Boutemy (JIRA) <j...@apache.org>
Subject [jira] [Comment Edited] (MPIR-234) SCM-link in site of multimodule projects should not append module name by default (at least for git)
Date Wed, 12 Aug 2015 00:07:47 GMT

    [ https://issues.apache.org/jira/browse/MPIR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692588#comment-14692588
] 

Hervé Boutemy edited comment on MPIR-234 at 8/12/15 12:07 AM:
--------------------------------------------------------------

I don't understand the idea of "report configuration"
but I completely agree with the idea of scm configuration that should be necessary only for
release root
and of course, no scm specific logic in Maven core

and that's what we get with extended git scm url

it's a general contract that should be enforcer for every supported scm (http://maven.apache.org/scm/scms-overview.html
): scm url should support going from a parent to a child Maven module by adding the path to
the url

in fact, our svn documentation saying {{scm:svn:http://[username[:password]@]server_name[:port]/path_to_repository}}
IMHO has always been misleading: it should probably be {{scm:svn:http://[username[:password]@]server_name[:port]/path_to_repository/path_inside_repository}}

the difference between svn and scms causing issues currently is that the separation between
path_to_repository and path_inside_repository is really enforced: hence the separator that
has to be added to clearly mark the difference


was (Author: hboutemy):
I don't understand the idea of "scm configuration"
but I completely agree with the idea of scm configuration that should be necessary only for
release root
and of course, no scm specific logic in Maven core

and that's what we get with extended git scm url

it's a general contract that should be enforcer for every supported scm (http://maven.apache.org/scm/scms-overview.html
): scm url should support going from a parent to a child Maven module by adding the path to
the url

in fact, our svn documentation saying {{scm:svn:http://[username[:password]@]server_name[:port]/path_to_repository}}
IMHO has always been misleading: it should probably be {{scm:svn:http://[username[:password]@]server_name[:port]/path_to_repository/path_inside_repository}}

the difference between svn and scms causing issues currently is that the separation between
path_to_repository and path_inside_repository is really enforced: hence the separator that
has to be added to clearly mark the difference

> SCM-link in site of multimodule projects should not append module name by default (at
least for git)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MPIR-234
>                 URL: https://issues.apache.org/jira/browse/MPIR-234
>             Project: Maven Project Info Reports Plugin
>          Issue Type: Bug
>          Components: scm
>    Affects Versions: 2.4
>            Reporter: Mirko Friedenhagen
>
> I have setup a simple multi module project (see https://github.com/mfriedenhagen/multi-module-sample/tree/multi-site-complex)
which uses git on github as {{scm}}. While rendering the site, MPIR will by default add the
name of the module to the SCM-URLs in source-repository.html. So instead of https://github.com/mfriedenhagen/multi-module-sample/
I see https://github.com/mfriedenhagen/multi-module-sample/core/, git@github.com:mfriedenhagen/multi-module-sample.git/core
and git://github.com/mfriedenhagen/multi-module-sample.git/core in the report for the core
module. All these URLs are invalid. For SVN this could be assumed to be the right behaviour,
for git and probably other SCMs this is not true. As a workaround I have to reconfigure the
scm section (see https://github.com/mfriedenhagen/multi-module-sample/blob/multi-site-complex/core/pom.xml)
in the modules like this:
> {code:xml}
> <scm>
>   <connection>${project.parent.scm.connection}</connection>
>   <developerConnection>${project.parent.scm.developerConnection}</developerConnection>
>   <url>${project.parent.scm.url}</url>
> </scm>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message